colesmj
colesmj
For what it is worth, I like this change, and think it doesn't go far enough (but maybe saves the need to fork the project or spin out an incubation...
@shambho Does your commit 3 days ago resolve this issue? If so, let's close this one. Alternately, or maybe also, we should document the object model on the wiki. I...
A couple of comments on this thread: > It would potentially be useful to know the source of a finding as automatic (from pytm detection) or manual (human added) or...
> > Source could also be an author, so that you have someone you can contact? > > > It would potentially be useful to know the source of a...
> > I'm open to making whatever fields as required that we all agree to, I just don't think its necessary and will lead to people putting junk data like...
> > Ok. I think I incorporated all of the comments. Only thing I didn't was @colesmj comment about do the findings need to be stored in the model. >...
Just another related note on `source` in a DataFlow - that is also the "initiator" (probably) of a comm flow, which another important attribute to have available.
See Issue #35 for how implementsCommunicationProtocol is used (incorrectly) now...
@nineinchnick Thanks for your feedback. Perhaps the response related items are properly used in DataFlow, but my other suggested changes I think are still valid, for the reasons I called...
Question on removing existing attrs: if a model attempts to set a non-existent attr, is the behavior to add it to the instance of the object? If so, then the...