colenso

Can someone help me out with tests? @locks perhaps?

Yes. But it always wasn't so. And I find it very handy to have it rebuild automatically when I change something in the environment.js file

Is this an issue with glimmer.js? If yes, will it be fixed in 2.0?

@sandydoo Please review 🙏

Closing this for now. I'll make a new PR which incorporates all the changes you've pointed out. Thanks 🙏

> In general, types should be imported where they need to be consumed. I think we would typically import them in specific files, where needed, rather than globally. I second...

@steveszc Would be nice to get this one in. I added some docs in https://github.com/steveszc/ember-simple-auth/pull/1. Please 🙏 review and merge so @BobrImperator can add these type defs in.

> @colenso I provided some feedback [here](https://github.com/steveszc/ember-simple-auth/pull/1#pullrequestreview-1361442486). A couple changes are needed to get it merged. I made the requested changes @steveszc Please merge if it's OK and then @BobrImperator...

👍

@mansona Can you please have a look at these changes? Maybe I shouldn't make this PR against `main`?