webform_civicrm icon indicating copy to clipboard operation
webform_civicrm copied to clipboard

WIP - Decouple list of payment processors from contribution page

Open jitendrapurohit opened this issue 4 years ago • 0 comments

Overview

Continuation of https://github.com/colemanw/webform_civicrm/pull/343. Decouple list of payment processors from contribution page

D7 or D8?

D7 for now. D8 port needed.

Before

Payment processor list depends on the contribution pages.

After

  • All Payment processor are listed on the contribution tab.
  • User-select removed from Payment processor mode so admins have to select either live or test.
  • fixPaymentProcessorID removed. Payment Processor id is now decided at the backend based on test/live selected on the config page.

@mattwire Can you skim through the second commit pls https://github.com/colemanw/webform_civicrm/commit/6e3153e60b0638eb57f74e9be25267cad79ecd67? I've removed few lines that I felt as not required based on our final discussion. Have tested this with different scenarios and all seem to work fine for me.

Comments

@KarinG This fixes the requirement for 1 & 2, i.e,

  1. add - User Select - to Payment Processor Mode (and then taking into account the setting for Mode -> only present Live (or Test) processors on the form.
  2. remove - User Select - from the Payment Processor Mode -> so that Admins have to pick Live or Test -> default should be Live.

jitendrapurohit avatar Oct 04 '20 10:10 jitendrapurohit