webform_civicrm icon indicating copy to clipboard operation
webform_civicrm copied to clipboard

Published 20 hours ago • verified publisher icon colemanw

CGP-1446: Rebase PR To 7.x-5.x - Allow multiple values with same location without swapping primary keys

Open vinuvarshith opened this issue 5 years ago • 2 comments

Overview

This PR is a rebase of PR#148. I was able to reproduce the issue as mentioned that PR on 7.x-5.x branch too and I can also confirm this PR fixes it.

Details

For more details and screenshots pls see PR#148

vinuvarshith avatar Sep 20 '19 10:09 vinuvarshith

You're refactoring code that was introduced in this PR - to address the issue described here: https://github.com/colemanw/webform_civicrm/pull/121 Can you please confirm that you've checked that the use issue addressed in that PR does not resurface?

KarinG avatar Sep 25 '19 12:09 KarinG

@jamienovick @vinuvarshith can you please check on the question Karin asked so we can get this PR closed?

colemanw avatar May 19 '20 19:05 colemanw