Cole Bemis

Results 78 comments of Cole Bemis

@japf this is looking great! @joshblack is going to take the lead on code review. He'll be your point-of-contact for any questions you have :)

Looks like this change causes the gap between the pane and content to be twice as large when there's no divider displayed: ![CleanShot 2022-10-19 at 10 41 02](https://user-images.githubusercontent.com/4608155/196765616-918baf3b-04a1-47c5-a364-d1130ed3fcf9.png)

👋 @japf FYI I'm going to work on getting this over the finish line today. Planning to polish some of the interactions and styling.

Update: I finished addressing @joshblack's comments. Here's a quick video demo: https://share.cleanshot.com/imPRk8 This should be ready for another round of review. cc @joshblack

@joshblack I think those odd behaviors are related to how we set the max width of the pane. The max width of the pane is relative to the entire viewport...

@joshblack I'm open to new ideas about how to handle min/max pane width if you have any! Here's the spec from @vdepizzol: https://github.com/github/primer/issues/581

Fixes https://github.com/github/primer/issues/1237

Yes, ST3 support, please!

@theKashey Thank you so much for the quick response! Approach #2 seems like the most reasonable solution. I'll give it a shot 😄

@theKashey Is there a way to use the "whitelist" approach in react-focus-on? It doesn't look like `FocusOn` exposes a `whitelist` prop