aiosmtplib icon indicating copy to clipboard operation
aiosmtplib copied to clipboard

Remove deprecated type hints

Open Vizonex opened this issue 4 weeks ago • 3 comments

I used ruff to upgrade the current codebase since 3.9 is not supported anymore and since typing.Union and typing.Optional are both deprecated I saw something that could be easily fixed up.

Vizonex avatar Dec 05 '25 02:12 Vizonex

Seeing how this library tests for uvloop I was wondering if I could add winloop to the mix in a later pull request?

Vizonex avatar Dec 05 '25 02:12 Vizonex

This looks great, thanks for the cleanup! Do you mind signing your commits, sorry that's a check I've been meaning to have in place for some time.

I'd accept a change to add winloop to the test suite, I think you should be able to follow the uvloop setup.

cole avatar Dec 05 '25 04:12 cole

I just needed to sign it I don't know exactly how to sign the others off since I've never signed commits before I did this one.

Vizonex avatar Dec 05 '25 19:12 Vizonex