Cole Helbling

Results 92 comments of Cole Helbling

How do you imagine this working? Would you want the bot email to be in the signoff?

@djmdjm Just wanted to ping you so that it's on your radar as an alternative to https://github.com/openssh/openssh-portable/pull/308.

Failing check seems to be a connection issue ("connection timed out"), unrelated to my changes.

I tested this just now, and it seems like you can specify the `store` in the `nix.conf` file (e.g. in `/etc/nix/nix.conf` or `~/.config/nix/nix.conf`).

I've finally run into my first issue with this branch: ``` $ nixos-rebuild --flake .#test build building the system configuration... warning: applying 'toString' to path '«github:nixos/nixpkgs/7e52b35fe98481a279d89f9c145f8076d049d2b9»/lib' and then accessing it...

Oh wow, exactly the same issue, too... Oops. I was so excited to have encountered something broken, and here it is already known and documented x) Sorry for the noise.

I believe https://github.com/NixOS/nix/pull/5090 implements this -- maybe give that a shot and report back on that PR?

FYI: it was tested on an x86 macOS VM (not aarch64 or on real hardware, but hopefully a close enough approximation?): https://github.com/NixOS/nix/pull/6882#discussion_r941603130. So, ideally, everything should be fine.

Would GitHub's built-in functionality not work for this? e.g.: ![image](https://user-images.githubusercontent.com/28582702/151434227-a9cfee03-9050-45c0-a0e7-6dd54ac90b4f.png) ("Learn more" link in the image: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/automatically-merging-a-pull-request)

I'd imagine it's because they try to network (e.g. `--sandbox false` would see these tests succeed), even if just with localhost. Best course of action to resolve this, however, I...