cbsecurity
cbsecurity copied to clipboard
Proposal to add ability to use CIDR signatures for IP addresses in coldbox rules
Description
I have a need to allow entire subnets access to a particular application. I would like to propose the following changes to allow this. This is fairly a big change due to a new module dependency so would like to hear your thoughts on this.
Please note that all PRs must have tests attached to them
tests to follow
Type of change
I have written and published a new module ( https://forgebox.io/view/ip ) and made changes to cbSecurity to use it so as to allow for CIDR addresses.
- [x] New Feature
Checklist
- [x] My code follows the style guidelines of this project cfformat
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
I think this looks great. Let me know when you want me to finalize and merge.
@ryanalbrecht is this ready to be merged?
@lmajano Good morning Luis,
Thinking about it I would like a couple more days to work on the ip module. The validation code for an ip address when instating the cfc could use some love.
Will let you know when Im comfortable sending this out into the wild.
Regards Ryan
No problem at all. We can also assist with your IP module if you like. I know @bdw429s loves that kinda stuff!
Sure, I will shoot him a message on slack
Any updates on this PR @ryanalbrecht
Any updates on this PR @ryanalbrecht
@lmajano Unfortunately I have not done any further development, I have been a bit swamped lately. I do actually intend to use this in one of the projects im working on so I will definitely get this code committed soon
Ready to commit, is it possible to rerun the tests to make sure all are passing?