cbsecurity icon indicating copy to clipboard operation
cbsecurity copied to clipboard

Proposal to add ability to use CIDR signatures for IP addresses in coldbox rules

Open ryanalbrecht opened this issue 1 year ago • 8 comments

Description

I have a need to allow entire subnets access to a particular application. I would like to propose the following changes to allow this. This is fairly a big change due to a new module dependency so would like to hear your thoughts on this.

Please note that all PRs must have tests attached to them

tests to follow

Type of change

I have written and published a new module ( https://forgebox.io/view/ip ) and made changes to cbSecurity to use it so as to allow for CIDR addresses.

  • [x] New Feature

Checklist

  • [x] My code follows the style guidelines of this project cfformat
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes

ryanalbrecht avatar Sep 05 '23 18:09 ryanalbrecht

I think this looks great. Let me know when you want me to finalize and merge.

lmajano avatar Sep 12 '23 19:09 lmajano

@ryanalbrecht is this ready to be merged?

lmajano avatar Sep 13 '23 09:09 lmajano

@lmajano Good morning Luis,

Thinking about it I would like a couple more days to work on the ip module. The validation code for an ip address when instating the cfc could use some love.

Will let you know when Im comfortable sending this out into the wild.

Regards Ryan

ryanalbrecht avatar Sep 13 '23 12:09 ryanalbrecht

No problem at all. We can also assist with your IP module if you like. I know @bdw429s loves that kinda stuff!

lmajano avatar Sep 13 '23 12:09 lmajano

Sure, I will shoot him a message on slack

ryanalbrecht avatar Sep 13 '23 12:09 ryanalbrecht

Any updates on this PR @ryanalbrecht

lmajano avatar Oct 10 '23 10:10 lmajano

Any updates on this PR @ryanalbrecht

@lmajano Unfortunately I have not done any further development, I have been a bit swamped lately. I do actually intend to use this in one of the projects im working on so I will definitely get this code committed soon

ryanalbrecht avatar Oct 10 '23 14:10 ryanalbrecht

Ready to commit, is it possible to rerun the tests to make sure all are passing?

ryanalbrecht avatar Oct 12 '23 14:10 ryanalbrecht