colcon-cmake icon indicating copy to clipboard operation
colcon-cmake copied to clipboard
verified publisher icon colcon

Args options for CMake `--build` and `--install`

Open KazNX opened this issue 4 years ago • 5 comments

Add --cmake-build-args to support passing arguments through to cmake --build Add --cmake-install-args to support passing arguments through to cmake --install

This PR supercedes https://github.com/colcon/colcon-cmake/pull/107 . See that PR for discussion history.

KazNX avatar Sep 28 '21 00:09 KazNX

This LGTM. cottsay ?

On my list for this week.

cottsay avatar Oct 10 '21 22:10 cottsay

@cottsay ping.

hidmic avatar Dec 06 '21 19:12 hidmic

@KazNX will you pick this up again in the near future? If not, I'll try and push this over the line. It'll benefit folks using colcon with ninja (like myself).

hidmic avatar Apr 05 '22 12:04 hidmic

@hidmic Been busy. I've posted some questions for @cottsay regarding how to go about implementing what he proposes.

KazNX avatar Apr 06 '22 00:04 KazNX

@ruffsl Follow up from IROS. I'm waiting on feedback on how to address the MAKEFLAGS questions. Personally, I'm not a fan of pulling from environment variables which are specific to a particular CMake generator - e.g., MAKEFLAGS is not relevant to MSBuild.

KazNX avatar Oct 30 '22 22:10 KazNX