colcon-cmake icon indicating copy to clipboard operation
colcon-cmake copied to clipboard

xunit.xml test results not found in --test-result-base

Open Aposhian opened this issue 4 years ago • 4 comments

#79 copies CTest Test.xml files over to the directory specified by --test-result-base, but not the *.xunit.xml result files. Since I am looking for my xunit "test results", the following documentation is misleading to me:

The base path for all test results. The default value is the --build-base argument. Each package uses a subdirectory in that base path as its package specific test result directory.

https://colcon.readthedocs.io/en/released/reference/verb/test.html

It seems like *.xunit.xml files should be copied over as well, or the documentation could be clarified.

Aposhian avatar Jun 28 '21 16:06 Aposhian

Perhaps documentation promises too much. colcon through colcon-cmake supports CTest. It doesn't (and cannot) account for whatever output those tests may generate. There isn't even a convention (e.g. a CMake variable) to be leveraged. So I agree documentation should warn that the set of test results may vary with each colcon extension supporting the test verb.

CC @dirk-thomas for feedback.

hidmic avatar Sep 10 '21 18:09 hidmic

colcon can only handle what it knows about. So rephrasing the documentation to make this explicit is probably the best approach.

dirk-thomas avatar Sep 17 '21 05:09 dirk-thomas

@Aposhian would you contribute a patch to docs?

hidmic avatar Sep 17 '21 12:09 hidmic

Yes I can do that.

Aposhian avatar Sep 17 '21 21:09 Aposhian