cointop icon indicating copy to clipboard operation
cointop copied to clipboard

Does not go full width at 1440p

Open Strykar opened this issue 3 years ago • 7 comments

At 2560x1440 resolution in a windowed (Alacritty) and full screen (Kitty) terminal, cointop does not extend fully to the right. See https://i.imgur.com/B5U210U.png

Strykar avatar May 08 '21 02:05 Strykar

Hi @Strykar, would you expect all the columns to be evenly spaced out in this case?

miguelmota avatar May 11 '21 20:05 miguelmota

@miguelmota Hi, yes, auto adjusting the columns based on width would be nice, esp. at higher resolutions.

Strykar avatar May 11 '21 20:05 Strykar

Is it the chart you're interested in, or the table? (the chart is easy/trivial, the table code would be a lot more involved)

Chart width option - https://github.com/miguelmota/cointop/pull/189

Set max_chart_width = 0 in config.toml then it looks like this: Screen Shot 2021-09-28 at 2 21 30 pm

lyricnz avatar Sep 28 '21 01:09 lyricnz

Is it the chart you're interested in, or the table? (the chart is easy/trivial, the table code would be a lot more involved)

No, that appears like the current chart with just the graph and date columns spilling over to the right.

Strykar avatar Sep 28 '21 12:09 Strykar

I asked: Is it the chart you're interested in, or the table? (and I provided a solution for the chart).

It seems you're interested in the table too? What do you suggest - just adding padding to all the columns evenly until it fills the space? This may make it hard to read / line-up?

lyricnz avatar Sep 28 '21 21:09 lyricnz

I asked: Is it the chart you're interested in, or the table? (and I provided a solution for the chart).

It seems you're interested in the table too? What do you suggest - just adding padding to all the columns evenly until it fills the space? This may make it hard to read / line-up?

Both, chart and table. Honestly I can't think of a better solution than padding, which may not be worth the effort as you point out.

Strykar avatar Mar 23 '22 08:03 Strykar

I would like to add that it happens for me on 1080p also, so it's probably independent of resolution. I also think padding is the best solution, as right now the columns seem squeezed together if the values are very large. Some coin names are even cut off, which doesn't make sense when there's so much space left.

deathtrip avatar Aug 16 '22 18:08 deathtrip