Refactor settle function to simplify signature handling
Description
Removed unnecessary parsing of ERC-6492 signatures in the settle function. The function now directly uses the payload signature, streamlining the code and improving readability. This change allows for modular accounts (ERC6900) who use different signature methods to work properly without breaking compatibility.
Tests
pnpm run test
Checklist
- [X] I have formatted and linted my code
- [X] All new and existing tests pass
- [X] My commits are signed (required for merge) -- you may need to rebase if you initially pushed unsigned commits
🟡 Heimdall Review Status
| Requirement | Status | More Info | ||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Reviews |
🟡
0/1
|
Denominator calculation
|
@giuseppecrj is attempting to deploy a commit to the Coinbase Team on Vercel.
A member of the Team first needs to authorize it.
Thanks a lot for the suggestion @giuseppecrj! The signature handling was improved in https://github.com/coinbase/x402/pull/713 and should cover this