fix(examples): correct typo in pnpm-workspace.yaml (mpc -> mcp)
๐ Bug Fix
Fixed a typo in examples/typescript/pnpm-workspace.yaml where "mpc" should be "mcp".
๐ Problem
The MCP (Model Context Protocol) example project at examples/typescript/mcp/ was not being recognized as part of the pnpm workspace due to this typo, causing module resolution errors:
Error [ERR_MODULE_NOT_FOUND]: Cannot find package '@modelcontextprotocol/sdk'
โ Solution
Changed "mpc" to "mcp" in the workspace packages list (line 9).
๐งช Testing
- [x] Ran
pnpm installsuccessfully after fix - [x] Verified MCP example can now resolve
@modelcontextprotocol/sdk - [x] Confirmed
node_modulessymlinks are created correctly inexamples/typescript/mcp/
๐ Files Changed
examples/typescript/pnpm-workspace.yaml(1 line)
๐ Additional Context
This appears to be a simple typo where "MCP" (Model Context Protocol) was accidentally typed as "mpc".
โ ๏ธ Note on Commit Signing
I noticed the CONTRIBUTING.md requires GPG signed commits. I don't have GPG configured on my system yet. If this is a blocker, I'm happy to:
- Install GPG and configure signing
- Amend and force-push the signed commit
Please let me know if you'd like me to add the signature before merging. Thank you!
โ Heimdall Review Status
| Requirement | Status | More Info | ||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Reviews |
โ
1/1
|
Denominator calculation
|
Someone is attempting to deploy a commit to the Coinbase Team on Vercel.
A member of the Team first needs to authorize it.
@CarsonRoscoe
Hey Carson,
Thank you for the guidance! I've completed all the requested changes:
โ
Ran Required Commands (from examples/typescript directory)
pnpm installโ - Completed successfully, no code changespnpm formatโ - All files properly formattedpnpm lintโ - All checks passed
โ Commit Updated
- Amended commit with GPG signature
- Force-pushed to branch
New Commit Details:
- Hash:
a6bad96fac9e32d63a0a7f216a50c321296b99ff - GPG Signature: โ Verified
- Status: All checks should now pass
Please let me know if there's anything else needed. Thank you! ๐
@CarsonRoscoe
All done! โ
I've completed all the requested changes:
- โ Configured GPG signing and signed the commit
- โ
Ran
pnpm install && pnpm format && pnpm lintfromexamples/typescriptdirectory - โ
Included the updated
pnpm-lock.yamlfile (fixed the CI frozen-lockfile error) - โ Amended and force-pushed the signed commit
Commit details:
- Hash:
e2b858bb720ce7d7b2024a0af6ee270f0c322cad - GPG Signature: โ Verified
- Files changed:
examples/typescript/pnpm-workspace.yaml(typo fix)examples/typescript/pnpm-lock.yaml(dependency updates)
The CI checks should now pass. Ready for review. Thanks for your guidance! ๐