x402 icon indicating copy to clipboard operation
x402 copied to clipboard

fix(examples): correct typo in pnpm-workspace.yaml (mpc -> mcp)

Open smartchainark opened this issue 2 months ago โ€ข 4 comments

๐Ÿ› Bug Fix

Fixed a typo in examples/typescript/pnpm-workspace.yaml where "mpc" should be "mcp".

๐Ÿ“ Problem

The MCP (Model Context Protocol) example project at examples/typescript/mcp/ was not being recognized as part of the pnpm workspace due to this typo, causing module resolution errors:

Error [ERR_MODULE_NOT_FOUND]: Cannot find package '@modelcontextprotocol/sdk'

โœ… Solution

Changed "mpc" to "mcp" in the workspace packages list (line 9).

๐Ÿงช Testing

  • [x] Ran pnpm install successfully after fix
  • [x] Verified MCP example can now resolve @modelcontextprotocol/sdk
  • [x] Confirmed node_modules symlinks are created correctly in examples/typescript/mcp/

๐Ÿ“ Files Changed

  • examples/typescript/pnpm-workspace.yaml (1 line)

๐Ÿ” Additional Context

This appears to be a simple typo where "MCP" (Model Context Protocol) was accidentally typed as "mpc".

โš ๏ธ Note on Commit Signing

I noticed the CONTRIBUTING.md requires GPG signed commits. I don't have GPG configured on my system yet. If this is a blocker, I'm happy to:

  1. Install GPG and configure signing
  2. Amend and force-push the signed commit

Please let me know if you'd like me to add the signature before merging. Thank you!

smartchainark avatar Nov 07 '25 17:11 smartchainark

โœ… Heimdall Review Status

Requirement Status More Info
Reviews โœ… 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

cb-heimdall avatar Nov 07 '25 17:11 cb-heimdall

Someone is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Nov 07 '25 17:11 vercel[bot]

@CarsonRoscoe

Hey Carson,

Thank you for the guidance! I've completed all the requested changes:

โœ… Ran Required Commands (from examples/typescript directory)

  • pnpm install โœ“ - Completed successfully, no code changes
  • pnpm format โœ“ - All files properly formatted
  • pnpm lint โœ“ - All checks passed

โœ… Commit Updated

  • Amended commit with GPG signature
  • Force-pushed to branch

New Commit Details:

  • Hash: a6bad96fac9e32d63a0a7f216a50c321296b99ff
  • GPG Signature: โœ… Verified
  • Status: All checks should now pass

Please let me know if there's anything else needed. Thank you! ๐Ÿ™

smartchainark avatar Nov 09 '25 03:11 smartchainark

@CarsonRoscoe

All done! โœ…

I've completed all the requested changes:

  1. โœ… Configured GPG signing and signed the commit
  2. โœ… Ran pnpm install && pnpm format && pnpm lint from examples/typescript directory
  3. โœ… Included the updated pnpm-lock.yaml file (fixed the CI frozen-lockfile error)
  4. โœ… Amended and force-pushed the signed commit

Commit details:

  • Hash: e2b858bb720ce7d7b2024a0af6ee270f0c322cad
  • GPG Signature: โœ… Verified
  • Files changed:
    • examples/typescript/pnpm-workspace.yaml (typo fix)
    • examples/typescript/pnpm-lock.yaml (dependency updates)

The CI checks should now pass. Ready for review. Thanks for your guidance! ๐Ÿ™

smartchainark avatar Nov 09 '25 04:11 smartchainark