x402 icon indicating copy to clipboard operation
x402 copied to clipboard

fix: clarify facilitator create_headers async contract

Open rnkrtt opened this issue 2 months ago • 2 comments

The docs claimed create_headers could be a plain function, but the client always awaits it, leading to runtime errors for sync callbacks. I updated the docstring and type so it clearly requires an async callable returning the headers.

rnkrtt avatar Nov 05 '25 12:11 rnkrtt

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

cb-heimdall avatar Nov 05 '25 12:11 cb-heimdall

@rnkrtt is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Nov 05 '25 12:11 vercel[bot]