x402 icon indicating copy to clipboard operation
x402 copied to clipboard

fix: remove unnecessary eslint-disable for comment text rendering

Open adarshswaminath opened this issue 2 months ago • 4 comments

Description

Removed unnecessary ESLint disables on https://github.com/coinbase/x402/blob/main/typescript/site/app/page.tsx#L229 Changed

<span className="text-gray-400">{'// and thats it!'}</span>

which renders the same without needing to disable the react/jsx-no-comment-textnodes rule.

Tests

Checklist

  • [x] I have formatted and linted my code
  • [x] All new and existing tests pass
  • [x] My commits are signed (required for merge) -- you may need to rebase if you initially pushed unsigned commits

adarshswaminath avatar Oct 24 '25 18:10 adarshswaminath

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

cb-heimdall avatar Oct 24 '25 18:10 cb-heimdall

@adarshswaminath is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Oct 24 '25 18:10 vercel[bot]