mesh-sdk-go icon indicating copy to clipboard operation
mesh-sdk-go copied to clipboard

Update spec to 1.4.15

Open sleepdefic1t opened this issue 1 year ago • 11 comments

Fixes # .

Motivation

Schnorr BIP-340 support in mesh-sdk-go first requires the addition of the appropriate curve and signature types found in the current specifications release.

Solution

Update mesh specification to 1.4.15 as discussed in #500

  • adds BIP-340 support to CurveType and SignatureType

sleepdefic1t avatar Nov 07 '24 23:11 sleepdefic1t

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 -1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

cb-heimdall avatar Nov 07 '24 23:11 cb-heimdall

This looks good to me, but I'll defer to @jingweicb or @GeekArthur for the changes to types/*

potterbm-cb avatar Nov 08 '24 01:11 potterbm-cb

Thank you, @potterbm-cb

I'll keep an eye out for any updates here 👍

sleepdefic1t avatar Nov 08 '24 01:11 sleepdefic1t

Hi @sleepdefic1t , how did you test the pr? can you add the testing in pr discriptions?

jingweicb avatar Nov 08 '24 17:11 jingweicb

Hi @sleepdefic1t , how did you test the pr? can you add the testing in pr discriptions?

I'm not sure I follow, @jingweicb

This PR only updates the spec version used by the SDK, what should be tested?


Our proposal to add BIP-340 support was shared by @GeekArthur here:

  • https://github.com/coinbase/mesh-specifications/discussions/113

Perhaps that discussion can provide clarity.

sleepdefic1t avatar Nov 08 '24 17:11 sleepdefic1t

@jingweicb

Just following up. Since there are no functional changes and no existing tests apply to this PR, would you prefer to merge this as-is, or are there adjustments you’d like to address first?

I'm ready to proceed whenever you are.

sleepdefic1t avatar Nov 11 '24 17:11 sleepdefic1t

Hi @sleepdefic1t , how did you test the pr? can you add the testing in pr discriptions?

I'm not sure I follow, @jingweicb

This PR only updates the spec version used by the SDK, what should be tested?

Our proposal to add BIP-340 support was shared by @GeekArthur here:

Perhaps that discussion can provide clarity.

Hi @GeekArthur , I think this pr matches the discussion raised by you, can you take a look?

I am ok once the pr can add the missing fields back also I suggest a test of derive endpoint as mentioned here https://github.com/coinbase/mesh-sdk-go/pull/509#discussion_r1838530603

jingweicb avatar Nov 12 '24 19:11 jingweicb

Hello @jingweicb @GeekArthur

I'd like to keep the momentum going here so that we may continue with adding BIP-340 support.

Please let me know how you'd like to proceed.

  • https://github.com/coinbase/mesh-sdk-go/pull/509#pullrequestreview-2430307509
  • https://github.com/coinbase/mesh-sdk-go/pull/509#pullrequestreview-2430442380
  • https://github.com/coinbase/mesh-sdk-go/pull/509#issuecomment-2471374262

sleepdefic1t avatar Nov 15 '24 13:11 sleepdefic1t

Hello @jingweicb @GeekArthur

Just following up again.

Please let me know how you'd like to proceed with this PR.

sleepdefic1t avatar Nov 25 '24 12:11 sleepdefic1t

Hello again, @GeekArthur and @jingweicb,

Please let me know how to proceed with this.

It’s been over two years since the work to add BIP-340 support was greenlit, and I’d greatly appreciate further direction on moving this forward.

sleepdefic1t avatar Dec 03 '24 19:12 sleepdefic1t

Hello @GeekArthur and @jingweicb,

Any update on this PR? We are still waiting :(

NayiemWillems avatar Jan 05 '25 23:01 NayiemWillems