Update spec to 1.4.15
Fixes # .
Motivation
Schnorr BIP-340 support in mesh-sdk-go first requires the addition of the appropriate curve and signature types found in the current specifications release.
Solution
Update mesh specification to 1.4.15 as discussed in #500
- adds BIP-340 support to
CurveTypeandSignatureType
🟡 Heimdall Review Status
| Requirement | Status | More Info | ||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Reviews |
🟡
-1/1
|
Denominator calculation
|
This looks good to me, but I'll defer to @jingweicb or @GeekArthur for the changes to types/*
Thank you, @potterbm-cb
I'll keep an eye out for any updates here 👍
Hi @sleepdefic1t , how did you test the pr? can you add the testing in pr discriptions?
Hi @sleepdefic1t , how did you test the pr? can you add the testing in pr discriptions?
I'm not sure I follow, @jingweicb
This PR only updates the spec version used by the SDK, what should be tested?
Our proposal to add BIP-340 support was shared by @GeekArthur here:
- https://github.com/coinbase/mesh-specifications/discussions/113
Perhaps that discussion can provide clarity.
@jingweicb
Just following up. Since there are no functional changes and no existing tests apply to this PR, would you prefer to merge this as-is, or are there adjustments you’d like to address first?
I'm ready to proceed whenever you are.
Hi @sleepdefic1t , how did you test the pr? can you add the testing in pr discriptions?
I'm not sure I follow, @jingweicb
This PR only updates the spec version used by the SDK, what should be tested?
Our proposal to add BIP-340 support was shared by @GeekArthur here:
Perhaps that discussion can provide clarity.
Hi @GeekArthur , I think this pr matches the discussion raised by you, can you take a look?
I am ok once the pr can add the missing fields back also I suggest a test of derive endpoint as mentioned here https://github.com/coinbase/mesh-sdk-go/pull/509#discussion_r1838530603
Hello @jingweicb @GeekArthur
I'd like to keep the momentum going here so that we may continue with adding BIP-340 support.
Please let me know how you'd like to proceed.
- https://github.com/coinbase/mesh-sdk-go/pull/509#pullrequestreview-2430307509
- https://github.com/coinbase/mesh-sdk-go/pull/509#pullrequestreview-2430442380
- https://github.com/coinbase/mesh-sdk-go/pull/509#issuecomment-2471374262
Hello @jingweicb @GeekArthur
Just following up again.
Please let me know how you'd like to proceed with this PR.
Hello again, @GeekArthur and @jingweicb,
Please let me know how to proceed with this.
It’s been over two years since the work to add BIP-340 support was greenlit, and I’d greatly appreciate further direction on moving this forward.
Hello @GeekArthur and @jingweicb,
Any update on this PR? We are still waiting :(