mesh-geth-sdk icon indicating copy to clipboard operation
mesh-geth-sdk copied to clipboard

Bump up go and go-ethereum version

Open cryptoriver opened this issue 1 year ago • 0 comments

Motivation

  1. bump up go-ethereum version from 1.10 to 1.12. The reason is because some rosetta nodes (e.g avalanche rosetta) are using more recent version and in order to use this SDK in these rosetta nodes, we need to bring it up to date as well.
  2. bump up go version from 1.16 to 1.19 and made relevant required code change. The reason is following the go-ethereum update, the old go version is no longer working as there's compile errors.
  3. Also fixed some lint error seeing in git action.

One add-on benefit of this update is that it can support Cancun upgrade (the latest signer is the Cancun signer) using 1.12.

Solution

Bump up the version and update relevant code as there's a minor broken change.

Also need to update one unit test.

Tests

  • unit tests.

Note: Rosetta node that is dependent on this SDK and wants to take this new version will need to take care of the regression tests and any needed code change.

Open questions

N/A

cryptoriver avatar Sep 21 '23 00:09 cryptoriver