mesh-ethereum
mesh-ethereum copied to clipboard
Missing `balance_exemptions` in `/network/options` -> `allow`
Hi team,
According to https://github.com/coinbase/rosetta-specifications/blob/master/models/Allow.yaml#L28,
The balance_exemptions
is required in the Options's Allow
entity. The field is missing in the following service implementation:
https://github.com/coinbase/rosetta-ethereum/blob/master/services/network_service.go#L65
Note that BalanceExemption could be an empty object!
There is a bit of inconsistency. 2 possible fixes:
- Fix the service by adding
balance_exemptions
. That field could even be an empty object. - Remove
balance_exemptions
from required in the openapi spec.
I know that in general, this is not a big issue, a client app can just ignore the missing balance_exemptions
. In my case, I'm using generated typescript clients using openapi generator. The parser breaks the whole call because it expects the field to be present.
Thanks! Fernando
Thanks for raising this. We will take a look to see what's the best way so that parser doesn't break for you.