coinbase-wallet-sdk icon indicating copy to clipboard operation
coinbase-wallet-sdk copied to clipboard

Bug: Unable to use signTypedData_v4 in snapshot.org

Open midgerate opened this issue 3 years ago • 6 comments

Describe the bug

In the compiled version of snapshot, I see an error but it works fine when running locally in dev

Steps

FYI - This might be snapshot.org specific problem, however it affects a large number of users of snapshot.org

  1. Go to this URL https://snapshot-ztk9cr4q9-snapshot.vercel.app/#/pistachiodao.eth/proposal/0x08c3bd2960700525770a1d634f8599ba967e55fcc05b6c1649d984d88253769d
  2. Connect with Coinbase wallet and try to vote
  3. You will see an error in console

image

This only happens on build version and does not happen on development mode.

Here's how we create the provider (its inside @snapshot-labs/lock package) image

Here's how we get the signer (its inside @snapshot-labs/snapshot.js package) image

Expected behavior

It should open the confirmation in the mobile phone app.

Version

3.0.11

Additional info

FYI - I haven't tested this with the coinbase wallet chrome extension.

Desktop

  • Browser - Chrome

Smartphone

  • OS Android

midgerate avatar May 08 '22 05:05 midgerate

Is this about me?

macky22am avatar May 09 '22 13:05 macky22am

Bug

macky22am avatar May 10 '22 19:05 macky22am

Any update on this?

samuveth avatar Aug 04 '22 08:08 samuveth

You can reproduce the issue on this proposal https://snapshot-ztk9cr4q9-snapshot.vercel.app/#/pistachiodao.eth/proposal/0x08c3bd2960700525770a1d634f8599ba967e55fcc05b6c1649d984d88253769d just connect wallet select a choice and try to vote and you should see the error in the console

bonustrack avatar Aug 04 '22 22:08 bonustrack

Coinbase Wallet supports both eth_signTypedData_v3 and eth_signTypedData_v4.

Can you please clarify -

  1. Are you testing using the Coinbase Wallet mobile app, or the browser extension?
  2. What version(s) are you using for testing?

taycaldwell avatar Aug 05 '22 09:08 taycaldwell

@taycaldwell The issue occurs when you connect with the mobile app to a desktop running snapshot in chrome via QR code scan.

My app version is 28.2.17

samuveth avatar Aug 05 '22 15:08 samuveth

hi. sorry for the belated response. we are marking stale issues closed for now. please try the latest CBWallet mobile app with version 28.23. feel free to open a new one if needed. thanks.

bangtoven avatar Jan 11 '23 00:01 bangtoven