coinbase-commerce-node icon indicating copy to clipboard operation
coinbase-commerce-node copied to clipboard

Feature request: Charge.resolve(code)

Open Falci opened this issue 5 years ago • 2 comments

It seems like the Charge object only supports create and retrieve. https://github.com/coinbase/coinbase-commerce-node/blob/0dbab8376bc17d15669917693b7d34fffd411598/lib/Resources/Charge.js#L15-L18

Would it be possible to add resolve ?

await Charge.resolve('AAAAAAAA');

Falci avatar Nov 22 '20 12:11 Falci

My temporary fix:

const coinbase = require('coinbase-commerce-node');

coinbase.resources.Charge.resolve = code =>
    axios.post(`https://api.commerce.coinbase.com/charges/${code}/resolve`, {
        headers: {
            'X-CC-Api-Key': COINBASE_APIKEY,
            'X-CC-Version': '2018-03-22',
        },
    });

Falci avatar Nov 22 '20 12:11 Falci

Hey @Falci - any gotchas I should be aware regarding this? I'm having some issues on my end trying to implement it. The other endpoints seem to be working properly though 🤔

zer0cache avatar Feb 08 '22 21:02 zer0cache