pulp icon indicating copy to clipboard operation
pulp copied to clipboard

Fixed error when PATH is not set

Open snajder-r opened this issue 3 years ago • 3 comments

Default for a missing PATH should be an empty string, not an empty list. Otherwise trying to call .split on it will throw AttributeError: 'list' object has no attribute 'split'

snajder-r avatar Mar 08 '22 08:03 snajder-r

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Mar 08 '22 08:03 CLAassistant

this makes a lot of sense, thanks. Can you please come up with a unittest to validate this and be sure it doesn't happen again? thanks again

pchtsp avatar Mar 08 '22 11:03 pchtsp

hello, can you pull the current master? I think the tests were failing for some other reason. Thanks and sorry for the delay.

pchtsp avatar Aug 13 '22 13:08 pchtsp

I'm closing since this issue was created, an alternative way to test the executable was found in 0c2b9418136406c7c54054f4ccbf0ec90b9787c4

pchtsp avatar Oct 02 '23 09:10 pchtsp