CoinUtils icon indicating copy to clipboard operation
CoinUtils copied to clipboard

Add CMake-based build support on stable/2.11

Open Mizux opened this issue 5 years ago • 4 comments

Add CMake based build + Makefile/docker CI + Travis-CI

Mizux avatar Feb 05 '20 15:02 Mizux

I am packaging CoinUtils up to google-or tools for conda right now and I am basing it off of your CMake files.

However, they don't seem to install a pkgconfig file, right? I think it would be nice to also configure a pkg-config file so that users of that toolchain can still use it.

wolfv avatar Feb 26 '20 07:02 wolfv

This patch was mainly to add Coin-OR to the CMake world (e.g. in order to consume it in google/or-tools when using the CMake build system, have a clean vcpkg package)...

Sure you can add pkg-config generation using CMake but:

  1. out of the scope of this PR IMHO, could be done in a later PR
  2. I'm currently not have a working business need for it, I need a Modern CMake config file to depends on it or be able to incorporate it to a super project build (see FetchContent)

Mizux avatar Feb 26 '20 08:02 Mizux

I understand what and why you're doing this -- but IMO this current CMake is wrong in this regard and it doesn't generate a "clean" recipe if it doesn't additionally install the pkg-config file since (especially in a package manager) other downstream packages might need / expect the file.

Btw. do you want to be part of the maintainers for the conda packages? I am adding or-tools next, just waiting for the (lib) protobuf build on conda to be based on CMake as well:

https://github.com/conda-forge/staged-recipes/pull/10935

wolfv avatar Feb 26 '20 08:02 wolfv

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jun 24 '20 13:06 CLAassistant