cohere-toolkit icon indicating copy to clipboard operation
cohere-toolkit copied to clipboard

Bugfix: Removed setup only dependency for makefile

Open samuelzxu opened this issue 9 months ago • 3 comments

Thank you for contributing to the Cohere Toolkit!

  • [ ] PR title: Bugfix: Removed setup only dependency for makefile

  • [ ] PR message: I've tried to install for debian 12 using the linux friendly instructions in the quickstart and the option 2 installation instructions. However, the make setup or make first-run commands fail with dependency errors for transformers and llama_cpp. I think this is because of the --only setup restriction in Makefile, which could restrict the dependency installs from pyproject.toml solely to setup dependencies rather than all dependencies.

    • Description: Removes the setup-only restriction
    • Dependencies: none

samuelzxu avatar May 03 '24 21:05 samuelzxu

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar May 03 '24 21:05 CLAassistant

Can I get more context on the issue? The initial poetry install with --only setup installs those dependencies on your local host machine to run the main.py CLI script, however make migrate and make dev should build the docker images for you, which runs

RUN pip install --no-cache-dir poetry==1.6.1 && \
poetry install --without setup

to install all dependencies.

Crucially, I'd like to know if the proposed fix resolves your issue

tianjing-li avatar May 03 '24 23:05 tianjing-li

The problem that I had was that the make setup script didn't run. It resulted in transformers and llama_cpp dependency errors. After removing the --only setup flag, the script run without errors.

samuelzxu avatar May 04 '24 13:05 samuelzxu

Hey @samuelzxu, the Makefile has been updated since the creation of this PR, I'll close this for now but if you're running into issues with the current make commands feel free to creating a new issue/PR as needed, thanks!

tianjing-li avatar May 09 '24 15:05 tianjing-li