cohere-toolkit icon indicating copy to clipboard operation
cohere-toolkit copied to clipboard

Minro refactoring for consistancy sake

Open Phodaie opened this issue 1 year ago • 3 comments

".

  1. The description should provide more details about the changes made in the pull request. It should also be concise and start with "

" and end with "

Phodaie avatar May 04 '24 15:05 Phodaie

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar May 04 '24 15:05 CLAassistant

I see one of the commits is not signed so you won't be able to merge the PR as is. To fix this, you can run the following command to sign all the commit history:

git rebase --exec 'git commit --amend --no-edit -n -S' -i --root

lusmoura avatar May 08 '24 09:05 lusmoura

Good morning,I have signed my commit. Please let me know if there is anything else I need to do.BTW, I enjoyed browsing the toolkit source code and learned a lot from it.Have a wonderful day,Payman Sent from my iPhoneOn May 8, 2024, at 5:18 AM, Luísa Moura @.***> wrote: I see one of the commits is not signed so you won't be able to merge the PR as is. To fix this, you can run the following command to sign all the commit history: exec git commit --amend --no-edit -S

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

Phodaie avatar May 08 '24 13:05 Phodaie

Hey @Phodaie! Thanks for checking out and contributing to Toolkit! Seems like your commits are still unverified. Check out https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits for more info about signing commits!

scott-cohere avatar May 09 '24 22:05 scott-cohere

@Phodaie looks good now. merging this in! thanks for your contribution :)

scott-cohere avatar May 10 '24 14:05 scott-cohere