core
core copied to clipboard
cogentcore
tableview scrollbar is positioned slightly out of position on first layout
Discussed in https://github.com/goki/goki/discussions/791
Originally posted by ddkwork January 12, 2024 When the horizontal and vertical scroll bars appear in the layout at the same time, when the mouse wheel scrolls up and down, the horizontal scroll bar should be manually dragged instead of the horizontal scroll bar scrolling at the same time as the vertical scroll bar is scrolling, because when this behavior occurs, the controls in the entire layout look at the center of the window or the right side of the window, and cannot visually preview all the controls on the layout. Recurrence: This can be seen by scrolling the mouse after loading the code on the app's global settings page, code editor, or gide's split layout.
Fixed in 739eb36370769e3abebea6a2806d220f9b67a7fe.
After testing the fix, it is still not possible to hold down the left mouse button to drag the vertical scrollbar, there is such a scenario that will often use this feature: when the table is very large, the mouse wheel will waste time and cannot scroll to the bottom of the table at one time, so we need both the mouse wheel feature and the left mouse button to press and drag. A bit off the visual is that the area where the cursor gets focus is always off the area drawn by the scrollbar, both horizontally and vertically, which can be confusing when using the scrollbar for the first time, and repeated testing has found that we need to trigger the cursor focus in the area that is about 2/5 off the scrollbar for subsequent dragging.
I propose that the scrollbar drawing area and the scrollbar up and down 1/5 of the area should actively set the focus of the cursor to trigger the draggable hand slap indicator icon, similar to the visual convenience of the operation There is also a variety of pop-up menus, if the mouse enters the first-level pop-up menu, the second-level menu will automatically pop up much better, and so on, which will reduce the user's multiple clicks on the pop-up menu operation ...
I am aware of the vertical scrollbar issue and will work on fixing it soon.
I am aware of the vertical scrollbar issue and will work on fixing it soon.
I found that the code is required to reproduce the bug, I can't describe the process in English, please see the code and gif
https://github.com/HyperDbg/gui
I am aware of the vertical scrollbar issue and will work on fixing it soon.
I forgot to say an operation to reproduce the bug: click on the global settings to adjust the values of zoom and space to force the bug to be triggered, because if I don't operate this, I test it like this, sometimes it is normal and sometimes it is abnormal
Looks to be specific to TableView (probably also SliceView), which has a vertical scrollbar managed by SliceGrid. This should be positioned a bit further to the left.
If you F5 or resize the window it puts the scroll in the right place, so the logic is correct in there at some level. The first show layout is not correct. I tried increasing render.go SceneShowIters from 2 to 3, 4 and it didn't fix it. Will require more detailed investigation..
Hello, I now have a scenario that reproduces the incorrect focus of the vertical scrollbar: load a very large json into the structview, at this point the vertical scrollbar is small, and when we pull at it, nothing happens. Happily, the UI is very smooth, because this json has more than 80MB, which is the capture record saved yesterday to test whether the long-term operation triggers the vulkan bug. Do you have time to test it from anydesk? Or I upload json to the network and the ui occasionally freezes. If I can, I'd like to join your github organization, and then you create a new private repository for the organization, and I'll upload the packet capture module to the repository.
I can reproduce the issue on my computer, so I shouldn't need that. I will work on fixing this soon.
thanks
---Original--- From: @.> Date: Mon, Feb 12, 2024 14:12 PM To: @.>; Cc: @.@.>; Subject: Re: [cogentcore/core] tableview scrollbar is positioned slightly outof position on first layout (Issue #797)
I can reproduce the issue on my computer, so I shouldn't need that. I will work on fixing this soon.
— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>
I can reproduce the issue on my computer, so I shouldn't need that. I will work on fixing this soon.
Now that the core has reached a usable state, I feel that it can be used for any production project, such as developing financial accounting software or something, and the scroll bar is the last minor flaw. Thank you for this time of restoration, the current use of core porting of previous projects and future projects is full of great recognition and recognition. Maybe we should release core to asomeone as soon as possible, more people involved in testing will make it more perfect, so that bugs and performance issues can be found on more platforms, and I'm surprised that sync demo I made actually caused so many bugs, hehe. MAP competition, empty slices, empty pointers, and check-in stuttering, it's really an impressive demo.
Yep, the async demo definitely helped reveal a lot of issues. We will release v1 of core after we finish all of the v1 milestone issues, which you can see here. We will definitely work on fixing this scrollbar bug soon.
good, I will keep the current fork to test again https://github.com/cogentcore/core/discussions/858 for a period of time, after 2-3 days the map will no longer trigger and null pointers, after asserting that the problem no longer appears, the commit other than the fork will be reset and keep in sync with you, when the time comes, I will also go to see if the problem in the milestone can be reproduced and participate in your solution, However, I found that I still don't understand the English translation of many issues.
---Original--- From: @.> Date: Fri, Feb 23, 2024 09:42 AM To: @.>; Cc: @.@.>; Subject: Re: [cogentcore/core] tableview scrollbar is positioned slightly outof position on first layout (Issue #797)
Yep, the async demo definitely helped reveal a lot of issues. We will release v1 of core after we finish all of the v1 milestone issues, which you can see here. We will definitely work on fixing this scrollbar bug soon.
— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>
We improved some of the table view scrolling logic recently; can you test it and see whether the issue still happens? If it does, can you give specific instructions on how to reproduce it?
Sorry I fell asleep, I just refreshed the commit, the first thing was to test vulkan, and found that I went to click on the header to sort while running the mini script, and after trying twice, I got the cgo system signal error during the time of adding to the 1300-1700 line, and the third time was to let the mini script operate, I didn't go to manipulate anything in the window, and ran to about 3,000 lines The most primitive panic came: vulkan exceeded the host memory. I have to test these commits well, and then test the scrollbar problem, and the last time I finally fixed it, I tried to make it run 30,000 lines, 50,000 lines or finish, 100,000 lines, and it was safe.
---Original--- From: @.> Date: Sun, Feb 25, 2024 04:33 AM To: @.>; Cc: @.@.>; Subject: Re: [cogentcore/core] tableview scrollbar is positioned slightly outof position on first layout (Issue #797)
We improved some of the table view scrolling logic recently; can you test it and see whether the issue still happens? If it does, can you give specific instructions on how to reproduce it?
— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>
I seem to see the same function call, come on, andesk, adding code as you thought earlier should fix it 1670379990
---Original--- From: @.> Date: Sun, Feb 25, 2024 04:33 AM To: @.>; Cc: @.@.>; Subject: Re: [cogentcore/core] tableview scrollbar is positioned slightly outof position on first layout (Issue #797)
We improved some of the table view scrolling logic recently; can you test it and see whether the issue still happens? If it does, can you give specific instructions on how to reproduce it?
— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>
We improved some of the table view scrolling logic recently; can you test it and see whether the issue still happens? If it does, can you give specific instructions on how to reproduce it?
GOROOT=C:\Users\Admin\go\pkg\mod\golang.org\[email protected] #gosetup
GOPATH=C:\Users\Admin\go #gosetup
C:\Users\Admin\go\pkg\mod\golang.org\[email protected]\bin\go.exe build -o C:\Users\Admin\AppData\Local\JetBrains\GoLand2023.3\tmp\GoLand\___3go_build_cogentcore_org_core_examples_async.exe cogentcore.org/core/examples/async #gosetup
C:\Users\Admin\AppData\Local\JetBrains\GoLand2023.3\tmp\GoLand\___3go_build_cogentcore_org_core_examples_async.exe
2024/02/25 09:04:42 panic: vulkan error: vulkan error: out of device memory (-2)
2024/02/25 09:04:42
2024/02/25 09:04:42 ----- START OF STACK TRACE: -----
2024/02/25 09:04:42 goroutine 21 [running]:
runtime/debug.Stack()
C:/Users/Admin/go/pkg/mod/golang.org/[email protected]/src/runtime/debug/stack.go:24 +0x5e
cogentcore.org/core/goosi.HandleRecoverBase({0x7ff738b4de20, 0xc10b77a840})
C:/Users/Admin/Desktop/core/goosi/recover.go:49 +0x4b
cogentcore.org/core/gi.HandleRecover({0x7ff738b4de20, 0xc10b77a840})
C:/Users/Admin/Desktop/core/gi/recover.go:32 +0x4b
cogentcore.org/core/gi.(*RenderWin).EventLoop.func1()
C:/Users/Admin/Desktop/core/gi/renderwin.go:555 +0x24
panic({0x7ff738b4de20?, 0xc10b77a840?})
C:/Users/Admin/go/pkg/mod/golang.org/[email protected]/src/runtime/panic.go:770 +0x132
cogentcore.org/core/vgpu.IfPanic(...)
C:/Users/Admin/Desktop/core/vgpu/errors.go:39
cogentcore.org/core/vgpu.(*Surface).ConfigSwapchain(0xc00035a580)
C:/Users/Admin/Desktop/core/vgpu/surface.go:263 +0x91a
cogentcore.org/core/vgpu.(*Surface).AcquireNextImage(0xc00035a580)
C:/Users/Admin/Desktop/core/vgpu/surface.go:360 +0xdf
cogentcore.org/core/vgpu/vdraw.(*Drawer).StartDraw(0xc00036e008, 0x0)
C:/Users/Admin/Desktop/core/vgpu/vdraw/draw.go:236 +0xd7
cogentcore.org/core/gi.(*RenderWin).DrawScenes(0xc0002a60f0)
C:/Users/Admin/Desktop/core/gi/renderwin.go:993 +0x262
cogentcore.org/core/gi.(*RenderWin).RenderWindow(0xc0002a60f0)
C:/Users/Admin/Desktop/core/gi/renderwin.go:957 +0x3b9
cogentcore.org/core/gi.(*RenderWin).HandleWindowEvents(0xc0002a60f0, {0x7ff73909bb40, 0xc109f097a0})
C:/Users/Admin/Desktop/core/gi/renderwin.go:619 +0x5ac
cogentcore.org/core/gi.(*RenderWin).HandleEvent(0xc0002a60f0, {0x7ff73909bb40, 0xc109f097a0})
C:/Users/Admin/Desktop/core/gi/renderwin.go:603 +0x11c
cogentcore.org/core/gi.(*RenderWin).EventLoop(0xc0002a60f0)
C:/Users/Admin/Desktop/core/gi/renderwin.go:569 +0x125
created by cogentcore.org/core/gi.(*RenderWin).GoStartEventLoop in goroutine 1
C:/Users/Admin/Desktop/core/gi/renderwin.go:523 +0xa5
2024/02/25 09:04:42 ----- END OF STACK TRACE -----
2024/02/25 09:04:42 SAVED CRASH LOG TO C:\Users\Admin\AppData\Roaming\Async Updating\crash-logs\crash_2024-02-25_09-04-42
2024/02/25 09:04:42 panic: vulkan error: vulkan error: out of device memory (-2)
2024/02/25 09:04:42
2024/02/25 09:04:42 ----- START OF STACK TRACE: -----
2024/02/25 09:04:42 goroutine 1 [running, locked to thread]:
runtime/debug.Stack()
C:/Users/Admin/go/pkg/mod/golang.org/[email protected]/src/runtime/debug/stack.go:24 +0x5e
cogentcore.org/core/goosi.HandleRecoverBase({0x7ff738b4de20, 0xc10d653bc0})
C:/Users/Admin/Desktop/core/goosi/recover.go:49 +0x4b
cogentcore.org/core/gi.HandleRecover({0x7ff738b4de20, 0xc10d653bc0})
C:/Users/Admin/Desktop/core/gi/recover.go:32 +0x4b
cogentcore.org/core/gi.Wait.func1()
C:/Users/Admin/Desktop/core/gi/renderwin.go:36 +0x24
panic({0x7ff738b4de20?, 0xc10d653bc0?})
C:/Users/Admin/go/pkg/mod/golang.org/[email protected]/src/runtime/panic.go:770 +0x132
cogentcore.org/core/vgpu.IfPanic(...)
C:/Users/Admin/Desktop/core/vgpu/errors.go:39
cogentcore.org/core/vgpu.(*Surface).ConfigSwapchain(0xc10ca77ce0)
C:/Users/Admin/Desktop/core/vgpu/surface.go:263 +0x91a
cogentcore.org/core/vgpu.(*Surface).Init(0xc10ca77ce0, 0xc0001fb408, 0x7ff738b13780?)
C:/Users/Admin/Desktop/core/vgpu/surface.go:119 +0x165
cogentcore.org/core/vgpu.NewSurface(0xc0001fb408, 0x1c84026bee0)
C:/Users/Admin/Desktop/core/vgpu/surface.go:68 +0x45
cogentcore.org/core/goosi/driver/desktop.(*App).NewWindow.func2()
C:/Users/Admin/Desktop/core/goosi/driver/desktop/app.go:139 +0x87
cogentcore.org/core/goosi/driver/desktop.(*App).MainLoop(0x7ff7397d9cc0)
C:/Users/Admin/Desktop/core/goosi/driver/desktop/app.go:68 +0x102
cogentcore.org/core/gi.Wait()
C:/Users/Admin/Desktop/core/gi/renderwin.go:42 +0x4b
cogentcore.org/core/gi.(*Stage).Wait(...)
C:/Users/Admin/Desktop/core/gi/stage.go:302
cogentcore.org/core/gi.(*Body).RunMainWindow(0x7ff738b61240?)
C:/Users/Admin/Desktop/core/gi/mainstage.go:38 +0x2b
main.main()
C:/Users/Admin/Desktop/core/examples/async/async.go:45 +0x2c5
2024/02/25 09:04:42 ----- END OF STACK TRACE -----
2024/02/25 09:04:42 SAVED CRASH LOG TO C:\Users\Admin\AppData\Roaming\Async Updating\crash-logs\crash_2024-02-25_09-04-42
进程 已完成，退出代码为 0
Can you try an earlier version of core (from yesterday, for example) and see if the Vulkan issue still happens? Just to confirm, the scrollbar issue is fixed, right? I will be available to debug on your computer in a few hours.
I just tried resetting to the previous commit and it still panics, I feel like I'm in a panic state myself, I feel like I'm going to crash
---Original--- From: @.> Date: Sun, Feb 25, 2024 10:14 AM To: @.>; Cc: @.@.>; Subject: Re: [cogentcore/core] tableview scrollbar is positioned slightly outof position on first layout (Issue #797)
Can you try an earlier version of core (from yesterday, for example) and see if the Vulkan issue still happens? Just to confirm, the scrollbar issue is fixed, right? I will be available to debug on your computer in a few hours.
— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>
I'm going to delete the version I added map to now and load mitmproxy to load the big json packet capture record file to test the scrollbar, before according to my default idea is to maintain the map version for a period of time, and test the concurrency problem of all widgets except the table for a long time, but vulkan's problem makes me feel very frustrated, delete it. If so, can you make it clear to the user to choose the backend? Or, like gio, it automatically selects the corresponding rendering environment for the platform, and gio can run on Windows pe. I'm very skeptical about the stability of vulkan under Windows, I don't know how many games call vulkan under Windows, and whether there are any relevant reports to refer to. According to your previous fix, the source code logic of the vulkan sdk has been broken to cater to Windows, but we can't satisfy it.
---Original--- From: @.> Date: Sun, Feb 25, 2024 10:14 AM To: @.>; Cc: @.@.>; Subject: Re: [cogentcore/core] tableview scrollbar is positioned slightly outof position on first layout (Issue #797)
Can you try an earlier version of core (from yesterday, for example) and see if the Vulkan issue still happens? Just to confirm, the scrollbar issue is fixed, right? I will be available to debug on your computer in a few hours.
— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>
We can absolutely fix Vulkan and get it working on Windows; please do not despair. Vulkan is used in many games and high performance apps on Windows and other platforms. I am confident that I will be able to fix Vulkan soon, and I will debug it on your computer later today. I am sorry for the continuing difficulties that these Vulkan issues have caused.
No, you've done a great job, and a lot of developers don't want to waste their time on testing, but you're more persistent and persuasive with you, and I appreciate your precise control over your code.
---Original--- From: @.> Date: Sun, Feb 25, 2024 10:29 AM To: @.>; Cc: @.@.>; Subject: Re: [cogentcore/core] tableview scrollbar is positioned slightly outof position on first layout (Issue #797)
We can absolutely fix Vulkan and get it working on Windows; please do not despair. Vulkan is used in many games and high performance apps on Windows and other platforms. I am confident that I will be able to fix Vulkan soon, and I will debug it on your computer later today. I am sorry for the continuing difficulties that these Vulkan issues have caused.
— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>
I'm going to go out to work to earn money tomorrow, and I can't play the computer at any time, is it convenient for you to debug today?
---Original--- From: @.> Date: Sun, Feb 25, 2024 10:29 AM To: @.>; Cc: @.@.>; Subject: Re: [cogentcore/core] tableview scrollbar is positioned slightly outof position on first layout (Issue #797)
We can absolutely fix Vulkan and get it working on Windows; please do not despair. Vulkan is used in many games and high performance apps on Windows and other platforms. I am confident that I will be able to fix Vulkan soon, and I will debug it on your computer later today. I am sorry for the continuing difficulties that these Vulkan issues have caused.
— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>
a.m 11:02 now to me
---Original--- From: @.> Date: Sun, Feb 25, 2024 10:29 AM To: @.>; Cc: @.@.>; Subject: Re: [cogentcore/core] tableview scrollbar is positioned slightly outof position on first layout (Issue #797)
We can absolutely fix Vulkan and get it working on Windows; please do not despair. Vulkan is used in many games and high performance apps on Windows and other platforms. I am confident that I will be able to fix Vulkan soon, and I will debug it on your computer later today. I am sorry for the continuing difficulties that these Vulkan issues have caused.
— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>
The vertical scrollbar doesn't work and can't be dragged
---Original--- From: @.> Date: Sun, Feb 25, 2024 10:29 AM To: @.>; Cc: @.@.>; Subject: Re: [cogentcore/core] tableview scrollbar is positioned slightly outof position on first layout (Issue #797)
We can absolutely fix Vulkan and get it working on Windows; please do not despair. Vulkan is used in many games and high performance apps on Windows and other platforms. I am confident that I will be able to fix Vulkan soon, and I will debug it on your computer later today. I am sorry for the continuing difficulties that these Vulkan issues have caused.
— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>
I can not debug right now, but I might be able to in a couple of hours.
It's great, I just received a call from my third uncle, I don't have to work for the time being, and I have more time to study and test core in the next period, and I'm currently unemployed, which is very bad
ok
---Original--- From: @.> Date: Mon, Feb 26, 2024 00:49 AM To: @.>; Cc: @.@.>; Subject: Re: [cogentcore/core] tableview scrollbar is positioned slightly outof position on first layout (Issue #797)
OK, I should be available to debug this later today.
— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>