core icon indicating copy to clipboard operation
core copied to clipboard

Implement clipboard support on mobile

Open ddkwork opened this issue 2 years ago • 6 comments

Screenshot_20231226_163543_com.org.todo.files.jpg

On Android devices, the text edit box does not have a double-click to select all text and a right-click to pop up the copy to clipboard menu

ddkwork avatar Dec 26 '23 08:12 ddkwork

Yes, I have been planning to implement copying on mobile and will do so soon. Thanks for reporting this.

kkoreilly avatar Dec 26 '23 17:12 kkoreilly

Why are you closing issues?

kkoreilly avatar Feb 15 '24 23:02 kkoreilly

Why are you closing issues?

The reports here (https://github.com/cogentcore/core/discussions/858) go on for a long time and are panic levels rather than time-consuming operations like widget expansion. This report bothered me for a long time, just like the previous Vulkan Panic, and we both understood what was causing it, and we knew how to write the code to fix it, and why we didn't fix it. In scenarios such as ERP, database, packet capture, etc., as long as these situations are triggered by back-end business-intensive tasks, can you fix any panic reports first? Instead of ignoring it outright. I don't like the verbosity of rust and the generic syntax of go, but it reduces the number of panic occurrences, don't you think?

ddkwork avatar Feb 16 '24 00:02 ddkwork

I apologize for all of the panics and the misunderstandings. I will focus on fixing all of the panics now. If you want to file a PR with your changes you said fixed certain panics, that would be helpful. Otherwise, I will work on debugging and fixing all of the panics you have mentioned.

kkoreilly avatar Feb 16 '24 02:02 kkoreilly

I'm trying to change the code, but this change may break the existing data structure and compatibility, and you need to verify it further, and when the demo I said is no longer panic and runs smoothly, I believe that some of the issues in all issues will disappear with it

---Original--- From: @.> Date: Fri, Feb 16, 2024 10:14 AM To: @.>; Cc: @.>;"State @.>; Subject: Re: [cogentcore/core] Implement clipboard support on mobile (Issue#710)

I apologize for all of the panics and the misunderstandings. I will focus on fixing all of the panics now. If you want to file a PR with your changes you said fixed certain panics, that would be helpful. Otherwise, I will work on debugging and fixing all of the panics you have mentioned.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you modified the open/close state.Message ID: @.***>

ddkwork avatar Feb 16 '24 03:02 ddkwork

I will try any PR and merge it if it works. The nil pointer dereferences and interface assertions should be relatively easy to fix, so I recommend that you do those in the places that it panics first. Please do not add nil checks to everything, only the places where it panics.

kkoreilly avatar Feb 16 '24 03:02 kkoreilly