Slava Akhmechet
Slava Akhmechet
Another data point-- clangd implements a semantic highlighting extension for inactive code. So for example if you're working on a C file, in VSCode the `#ifdef` sections for other platforms...
> What's returned by: `["fo" ,"o"].coerceTo('string')` Err, I didn't think of this. The obvious option is `'foo'`, though introduction of this edge case suggests others like `['f', 1, 'o']` which...
I'm just full of holes today. Heh.
@jperkin -- are you completely opposed to signing the CLA (http://rethinkdb.com/community/cla/)? It's all online and only takes a few seconds. Unfortunately if we don't follow this process, we'll have to...
Thanks @bcantrill -- the CLA is definitely the most expedient path (but not the only one, if it's unworkable for you guys). FYI, all it does is signs off the...
Got it, thanks! @danielmewes @AtnNn -- feel free to merge if/when it's appropriate.
- I haven't signed the CLA, but happy to. Will do that. - All the code review comments are really good, thank you! I'll fix these up and update the...
I just pushed a version of the PR that addresses all the inline comments. Re `hide-ifdef-mode` I think the feedback is reasonable. TBH I only glanced at the mode and...
Done and done. FYI re hiding— clangd labels the code _between_ `#ifdef … #end` as inactive, but ccls labels code _including_ `#ifdef … #end` as inactive. This is something I...
Sorry I got back to my day job after xmas break and dropped the ball on this. Just signed the doc and sent it to fsf. On Wed, Feb 21,...