mozart icon indicating copy to clipboard operation
mozart copied to clipboard

When I set delete_vendor_directories to false vendor directory gets emptied anyways

Open dmnyk opened this issue 5 years ago • 4 comments

When I set "delete_vendor_directories" to false it seems like it behaves like true, i.e. results in an empty folder.

dmnyk avatar Jul 09 '20 10:07 dmnyk

Post an example composer.json and I'll give it a try.

BrianHenryIE avatar Jul 17 '20 07:07 BrianHenryIE

Presumably using

{
    "require-dev": {
        "coenjacobs/mozart": "*",
  }
} 

is using the 0.5.1 "release" version (pre current betas) which does not have the delete_vendor_directories PR merged.

So "releases" is not aligned with "master". Best bet is maybe to start a "dev" branch to reduce confusion.

I presume this issue should be closed.

BrianHenryIE avatar Aug 11 '20 05:08 BrianHenryIE

Hi @BrianHenryIE . I am sorry for late reply. My composer file looks something like this:


{
    "require-dev": {
        "coenjacobs/mozart": "^0.5.1"
    },
    "extra": {
        "mozart": {
            "dep_namespace": "TheTest\\",
            "dep_directory": "/thetest/",
            "classmap_directory": "/classes/dependencies/",
            "classmap_prefix": "",
            "packages": [
                "respect/validation"
            ],
            "delete_vendor_directories": false
        }
    },
    "require": {
        "respect/validation": "^2.0"
    }
}

dmnyk avatar Aug 11 '20 06:08 dmnyk

I can definitely reproduce using your exact pasted compser.json.

It does not occur if you use

"require-dev": {
    "coenjacobs/mozart": "0.6.0-beta-3"
},

And does not occur if you want to live wild with:

{
    "minimum-stability": "dev",
    "require-dev": {
        "coenjacobs/mozart": "*"
    },
    ...
}

So it looks as though master documentation is out of sync with what composer treats as release code (fair enough). Maybe somebody knows the nuances of dev branches and releases and could input, but I don't have enough experience to suggest the best approach.

BrianHenryIE avatar Aug 20 '20 09:08 BrianHenryIE