prboom-plus icon indicating copy to clipboard operation
prboom-plus copied to clipboard

Uniformly format source code

Open fabiangreffrath opened this issue 5 years ago • 2 comments

Hi, PrBoom+'s source code is currently a pain to work with. This is - among others - due to the multitude of different and inconsistent coding and indentation styles applied by a variety of different code authors over the past two decades. I'd suggest to apply a cesura here and now by deciding for a single consistent coding style to apply to all code covered by the project. We should use tools like e.g. clang-format or gnu indent to define a style and provide the corresponding configuration along with the source code.

Cheers, Fabian

fabiangreffrath avatar Sep 30 '19 12:09 fabiangreffrath

I have nothing against it and agree that the formatting is awful. The main reason I nornally avoid such things is that it often trashes any chance to do change history checks on a file.

coelckers avatar Sep 30 '19 15:09 coelckers

Another downside is that it instantly destroys every single patch that's available out there.

fabiangreffrath avatar Sep 30 '19 16:09 fabiangreffrath