2nfm icon indicating copy to clipboard operation
2nfm copied to clipboard

Enable text chat

Open codysherman opened this issue 5 years ago • 7 comments

Let the viewers chat with each other.

codysherman avatar Sep 22 '19 19:09 codysherman

Working on this currently

andmarek avatar Feb 29 '20 19:02 andmarek

@andmarek has completed the code that talks to the backend, so this is just waiting on updated UI from @bfrisch1 @AdarBS

sammoore avatar Mar 01 '20 17:03 sammoore

@samtheprogram says he's received the frontend UI from @AdarBS. @JohnmarkBeaty expressed interest in building this once that has happened.

codysherman avatar Jun 16 '20 19:06 codysherman

Post-hackathon-mayhem, I am not sure where @andmarek's pushed code that talks to the backend is -- if we don't hear back from him, we can re-implement as RTCMultiConnection provided most of the heavy lifting here anyway.

In the event we need to re-implement some of this logic, the original implementation from the hackathon utilized RTCMultiConnection's send method.

sammoore avatar Jun 16 '20 19:06 sammoore

As far as UI goes, see the branch chat-styles or chat-room-js for what was done by @AdarBS and @bfrisch1.

The two branches diverged, so there are some missing commits from @bfrisch1 not present in chat-room-js, but they may not be necessary as @AdarBS's latest changes in chat-room-js, which came later, was explicitly for polish.

sammoore avatar Jun 16 '20 19:06 sammoore

Adar's work goes far beyond mine, I can check and try and push anything that stands out (sorry about that) but I doubt it's important. He took my branch and ran with it.

On Tue, Jun 16, 2020 at 1:48 PM Sam Moore [email protected] wrote:

As far as UI goes, see the branch chat-styles or chat-room-js for what was done by @AdarBS https://github.com/AdarBS and @bfrisch1 https://github.com/bfrisch1.

The two branches diverged, so there are some missing commits from @bfrisch1 https://github.com/bfrisch1 not present in chat-room-js, but they may not be necessary as @AdarBS https://github.com/AdarBS's latest changes in chat-room-js, which came later, was explicitly for polish.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/codysherman/2nfm/issues/56#issuecomment-644976604, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADCHIMNECVQZNA2VVF5GU2DRW7EARANCNFSM4IZEFCIA .

bfrisch1 avatar Jun 16 '20 19:06 bfrisch1

I can take a look a little later

danstepanov avatar Jun 16 '20 20:06 danstepanov