Disable like/bookmark buttons on loading query

[boldurean]

✨ Codu Pull Request 💻

Pull Request details

• Added disabled attribute to like/bookmark buttons while requests are pending.
• use isLoading (bool) prop instead of status as non any other mutation statuses are used in component.

Any Breaking changes

• None

Associated Screenshots

• 'None'

Summary by CodeRabbit

• Refactor
  • Updated variable names in the Article Menu to better reflect the loading status for liking and bookmarking actions.

[vercel[bot]]

Someone is attempting to deploy a commit to the Codú Team on Vercel.

A member of the Team first needs to authorize it.

[coderabbitai[bot]]

Walkthrough

The update in the ArticleMenu.tsx file focuses on improving the clarity of variable names that manage the UI state for user interactions such as liking and bookmarking articles. The renaming of these variables enhances readability and better reflects their function as indicators of pending actions.

Changes

File Path	Change Summary
.../ArticleMenu/ArticleMenu.tsx	Renamed likeStatus to isPendingLike and bookmarkStatus to isPendingBookmark to clarify their roles as indicators of pending actions.

Poem

🐇 A little rabbit's ode to code:

In the garden of syntax, under the code tree, 🌳
A little rabbit tweaked the names, with glee.
likeStatus now waits, as isPendingLike,
bookmarkStatus follows, a similar hike.
With every hop and every tweak, the code shines bright,
Making every user's click just right. 🌟

---

Recent Review Details

Configuration used: CodeRabbit UI Review profile: CHILL

Commits

Files that changed from the base of the PR and between 480c60978e7a17278daebf81fc2f82b3a093c77b and 52d9dcf1c8ba7db2c8f5c514f9985b5d7f94226a.

Files selected for processing (1)

• components/ArticleMenu/ArticleMenu.tsx (4 hunks)

Additional comments not posted (4)

components/ArticleMenu/ArticleMenu.tsx (4)

61-61: The introduction of isPendingLike to manage the loading state of the like action is a good simplification of state management.

---

67-67: The introduction of isPendingBookmark to manage the loading state of the bookmark action aligns well with the PR's objectives.

---

126-126: Disabling the like button while the like action is pending is a practical enhancement to the user interface.

---

149-149: Disabling the bookmark button while the bookmark action is pending enhances the user experience by preventing duplicate interactions.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[JohnAllenTech]

Hey @boldurean I was able to replicate this issue locally when I throttled my connection

This makes the query more life like as the request will (unfortunately) not complete in 10ms like it does locally.

Please see attached video

https://github.com/codu-code/codu/assets/46611809/d811991c-0d6c-46aa-b28e-313ba845f6b1

[boldurean]

Hey @boldurean I was able to replicate this issue locally when I throttled my connection

This makes the query more life like as the request will (unfortunately) not complete in 10ms like it does locally.

Please see attached video

882e98f9-a23d-4912-ab73-f5abaf8c5168.mp4

Hey @JohnAllenTech thanks for reviewing it. I think something with a backend async process the queue isn't sequential. Let me think about this more.

[JohnAllenTech]

Hey @boldurean I was able to replicate this issue locally when I throttled my connection This makes the query more life like as the request will (unfortunately) not complete in 10ms like it does locally. Please see attached video 882e98f9-a23d-4912-ab73-f5abaf8c5168.mp4

Hey @JohnAllenTech thanks for reviewing it. I think something with a backend async process the queue isn't sequential. Let me think about this more.

No problem. You could be right! Heres a link to where the action is happening https://github.com/codu-code/codu/blob/480c60978e7a17278daebf81fc2f82b3a093c77b/server/api/router/post.ts#L196