codu icon indicating copy to clipboard operation
codu copied to clipboard

Editor: fixed menu should hide when clicking publish

Open xiaoniuniu89 opened this issue 1 year ago • 11 comments

Context

We have a fixed menu at the top of our new editor

Expected Behavior

when user clicks the publish button, the menu should not be visable

Current Behavior

visable from publish screen

Screenshots

Screenshot 2023-10-08 at 21 46 39

Steps to reproduce

Please provide detailed steps for reproducing the issue

go to alpha/create/new click publish button

Additional info

xiaoniuniu89 avatar Oct 08 '23 20:10 xiaoniuniu89

Hey Niu. I will try this tomorrow.

John-Paul-Larkin avatar Oct 09 '23 21:10 John-Paul-Larkin

@Fishamble are you taking this one?

NiallJoeMaher avatar Oct 12 '23 20:10 NiallJoeMaher

Hi @NiallJoeMaher . I will like to contribute to this or fix any other ticket that hasn't been resolved yet

VickTor61 avatar Oct 15 '23 23:10 VickTor61

Hi Vicktor. I am not working on this, so you can give it a try.

John-Paul-Larkin avatar Oct 16 '23 18:10 John-Paul-Larkin

Hi @NiallJoeMaher, looks like the issue is with css, its been a week there is no activity in this issue. If no one is working I can open a PR!

vrun1208 avatar Oct 24 '23 11:10 vrun1208

@VickTor61 are you working on this or can I pass it over to @vrun1208?

NiallJoeMaher avatar Oct 24 '23 12:10 NiallJoeMaher

@NiallJoeMaher currently working on it I should make a PR later today

VickTor61 avatar Oct 24 '23 14:10 VickTor61

@NiallJoeMaher The error doesn't show in development, Has it already been fixed? Screenshot 2023-10-25 at 5 43 03 AM

VickTor61 avatar Oct 25 '23 04:10 VickTor61

Hi Vick. You are looking at the wrong editor. http://localhost:3000/alpha/new is the url for the alpha editor. app/alpha/new/[..postidarr]/client.tsx is the component.

John-Paul-Larkin avatar Oct 27 '23 21:10 John-Paul-Larkin

Hey there, I have a solution for this problem put together. Could I have this assigned to me so I can create a PR?

danboyce92 avatar Jan 02 '24 14:01 danboyce92

I already fixed this issue earlier! @NiallJoeMaher can I open a PR!

vrun1208 avatar Jan 02 '24 15:01 vrun1208