TabNine icon indicating copy to clipboard operation
TabNine copied to clipboard

Inline completions - user feedback

Open dimacodota opened this issue 3 years ago • 139 comments

Hi All, we just released an experimental "inline Completions" feature 🎉

Please share your experience with this feature🙏

In order to enable it:

  • make sure you are using the latest engine(3.5.37) and extension(3.4.21) version.
  • open the Tabnine Home(from the status bar item), scroll to "General Preferences" and check the "inline Completions" option
  • restart vscode
Screen Shot 2021-08-08 at 11 15 14

dimacodota avatar Aug 04 '21 20:08 dimacodota

I'm possibly being dumb here but where is Tabnine Home? I can only see the regular VSCode preferences and I don't seem to be able to find anywhere to download the Tabnine engine separately (i.e. only the various extensions) which is what's implied by the instructions.

rcoundon avatar Aug 08 '21 09:08 rcoundon

I'm possibly being dumb here but where is Tabnine Home? I can only see the regular VSCode preferences and I don't seem to be able to find anywhere to download the Tabnine engine separately (i.e. only the various extensions) which is what's implied by the instructions.

click on the "Tabnine" status bar item: Screen Shot 2021-08-08 at 12 07 15

dimacodota avatar Aug 08 '21 09:08 dimacodota

I'm possibly being dumb here but where is Tabnine Home? I can only see the regular VSCode preferences and I don't seem to be able to find anywhere to download the Tabnine engine separately (i.e. only the various extensions) which is what's implied by the instructions.

click on the "Tabnine" status bar item: Screen Shot 2021-08-08 at 12 07 15

Great - thank you

rcoundon avatar Aug 08 '21 11:08 rcoundon

Does it allow to see one suggestion only?

dreambit avatar Aug 11 '21 21:08 dreambit

Does it allow to see one suggestion only? you can "list" through the suggestions via alt +[ and alt +] keys Screen Shot 2021-08-12 at 0 53 11

dimacodota avatar Aug 11 '21 21:08 dimacodota

I honestly find it better than the popup since I have a lot of snippets that I use the tab space I didn't like the fact that the suggestions crowded out the snippets.

What would be perfect is that I could see the other suggestions somewhere so it don't waste time I circling them with the alt +[

Since I used tabnine to be faster I would like to see it fast if there are any suggestions that I can use.

StefnirKristjansson avatar Aug 18 '21 00:08 StefnirKristjansson

When using lens-related plugins like Error lens and Git lens, it breaks Tabnine's autocomplete.

xusine avatar Aug 18 '21 22:08 xusine

Looks like a cool feature. It does not seem to work in the IntelliJ Plugin though. Is this something that is in the works?

HippieHosenHustler avatar Aug 19 '21 08:08 HippieHosenHustler

Looks like a cool feature. It does not seem to work in the IntelliJ Plugin though. Is this something that is in the works?

Yes, we are working on it. It should be released soon

Eransho avatar Aug 19 '21 10:08 Eransho

Love this feature when combined with the Full Line completions. However, I have two requests/questions:

  1. Would it be possible to add a switch (or be default) that if we have full line completion turned on, it will instead show its longest prediction first. I just find myself sometimes having to use the 'ctr + [ OR ]' to cycle from completing the current word (which is accurate) to the full line which is a bit cumbersome

  2. Somehow combine inline with a dropdown? Like it would show the first auto-complete suggestion inline, but all other options would appear in a dropdown (either the current drop down style, or a different one).

#2 is key because it shows whether I will waste time cyclying through each one with the hot keys or not.

Other than that, great work!

DenysAshikhin avatar Aug 19 '21 15:08 DenysAshikhin

love this feature :)

IRediTOTO avatar Aug 21 '21 08:08 IRediTOTO

In VSCode the suggestion sometimes appears in front of the text. Seems to only happen when starting a new line. fixes itself after waiting for a bit

this might be caused by the fact that the files im working on are on a remote network drive and therefore have limited bandwith and latency, though tabnine really shouldn't need direct file access for individual predictions.

edit: hmm, also happens with lines when you add closing symbols and then jump before them, so it might not be related to it being a new line

edit 2: this is happening all the time now. im going to have to turn this great feature off until it stops moving my cursor due to suggestions popping up infront of the cursor, as that is really jarring. it should NEVER move my cursor no matter for how short, which it currently does, see the videos:

stopped typing, you can see the cursor move forwards and back:

https://user-images.githubusercontent.com/24855949/130456033-c6594e5a-2fa7-4e34-8fb4-0907a2a10a97.mp4

didn't stop typing:

https://user-images.githubusercontent.com/24855949/130455413-d3f55436-5d41-43e8-be57-46a1066b65ca.mp4

laundmo avatar Aug 23 '21 12:08 laundmo

There's occasions where pressing Tab to accept an inline-completion results in either an actual tab being inserted, or it prefers the first option of a dropdown Intellisense suggestion instead.

To prevent the latter, I've completely disabled the dropdowns from VSCode entirely.

However, in this .md file for example, the issue still persists

https://user-images.githubusercontent.com/2586027/130464528-21d5733a-ab00-4035-a3e1-a0d86136a429.mov

Settings: image image

shmkane avatar Aug 23 '21 14:08 shmkane

There's occasions where pressing Tab to accept an inline-completion results in either an actual tab being inserted, or it prefers the first option of a dropdown Intellisense suggestion instead.

To prevent the latter, I've completely disabled the dropdowns from VSCode entirely.

However, in this .md file for example, the issue still persists

Screen.Recording.2021-08-23.at.10.26.24.AM.mov Settings: image image

@shmkane, can you please share your console log (Help -> Toggle Developer Tools) ?

dimacodota avatar Aug 23 '21 14:08 dimacodota

There's occasions where pressing Tab to accept an inline-completion results in either an actual tab being inserted, or it prefers the first option of a dropdown Intellisense suggestion instead. To prevent the latter, I've completely disabled the dropdowns from VSCode entirely. However, in this .md file for example, the issue still persists Screen.Recording.2021-08-23.at.10.26.24.AM.mov Settings: image image

@shmkane, can you please share your console log (Help -> Toggle Developer Tools) ?

Here's me attempting to tab complete on a markdown file vs a javascript file.

https://user-images.githubusercontent.com/2586027/130484757-fd01a9c4-f04d-4802-b0c2-0873b9044a5a.mov

I'm unsure if the errors displayed are related, but here's a PasteBin of the output shown in the video

shmkane avatar Aug 23 '21 16:08 shmkane

@shmkane - can you please share the list of your installed extensions code --list-extensions?

dimacodota avatar Aug 23 '21 18:08 dimacodota

@shmkane - can you please share the list of your installed extensions code --list-extensions?

code --list-extensions

christian-kohler.npm-intellisense
christian-kohler.path-intellisense
CoenraadS.bracket-pair-colorizer-2
dbaeumer.vscode-eslint
discountry.react-redux-react-router-snippets
donjayamanne.python-extension-pack
eamodio.gitlens
eg2.vscode-npm-script
esbenp.prettier-vscode
janisdd.vscode-edit-csv
jasonnutter.search-node-modules
jawandarajbir.react-vscode-extension-pack
k--kato.intellij-idea-keybindings
KevinRose.vsc-python-indent
magicstack.MagicPython
ms-python.python
ms-python.vscode-pylance
naumovs.color-highlight
njpwerner.autodocstring
richie5um2.vscode-sort-json
rvest.vs-code-prettier-eslint
streetsidesoftware.code-spell-checker
TabNine.tabnine-vscode
VisualStudioExptTeam.vscodeintellicode
vscode-icons-team.vscode-icons
xabikos.JavaScriptSnippets
xabikos.ReactSnippets
yzhang.markdown-all-in-one
zhuangtongfa.material-theme

shmkane avatar Aug 23 '21 18:08 shmkane

it seems will quit edit mode and turn to visual mode with vsocde vim in some cases

xuzhanhh avatar Aug 24 '21 10:08 xuzhanhh

it seems will quit edit mode and turn to visual mode with vsocde vim in some cases

same for me, but almost all time

lastgosumatt avatar Aug 26 '21 08:08 lastgosumatt

it seems will quit edit mode and turn to visual mode with vsocde vim in some cases

Yes, almost all the time here too.

Mattiaslndstrm avatar Aug 26 '21 12:08 Mattiaslndstrm

Fantastic feature!

I think it would be great if pressing arrow down or up(to select from the regular dropdown list) would disable the feature temporarily to allow tab to pick from the regular dropdown instead.

Magnusri avatar Aug 30 '21 08:08 Magnusri

What I personally noticed is that the inline completetions aren't really compatible with the vscode vim plugin (vscodevim.vim). When using a suggested completion by pressing tab, the vim plugin will go into visual mode, the vim cursor stays at the last typed character but a "normal", thin cursor will appear at the end of the completed code. This is quite an annoyance as you can't keep typing but instead need to spam esc to get back into normal mode and then move your cursor to the end again and go into insert mode before you can start typing again.

hugohabicht01 avatar Aug 30 '21 10:08 hugohabicht01

I've experienced the same issues as several others in the thread with this feature with the Vim extension for VS Code.

I also noticed similar issues with the markdown extension breaking tab auto completion as described by @shmkane. Based on my own experience with a simple navigation extension I wrote, it seems like the markdown extension specifically captures input overzealously - I noticed that it broke the backspace keybinding I use in my extension. I've only noticed that behavior when editing markdown files so far. Not sure if that's helpful at all for narrowing down that issue.

As a feature request, it would be nice if there was a way to request inline suggestions, similar to how ctrl+space opens the regular suggestion dropdown.

shadowndacorner avatar Sep 01 '21 04:09 shadowndacorner

I sometimes just use Tabnine as a kind of AI-assisted lexicon of what i may need, so I would suggest that it does show the other options too, instead of having to manually expand the other options, I'd like to see the inline suggestion, and the others too. (PHPStorm)

frizzant avatar Sep 02 '21 09:09 frizzant

I can't make it work, when a suggestion appears, i hit tab and just a TAB character appears :( I'm using VSCode 1.59.1, tabnine plugin: 3.4.26 and engine: 3.6.5-40 pro. Any help?

Thank you

jrrmcalcio avatar Sep 02 '21 16:09 jrrmcalcio

Does this feature work with Jetbrains at all? I can't make it work on PHPStorm.

igorsgm avatar Sep 02 '21 17:09 igorsgm

VS code just release new version inludes inline complete. Should I remove tab9 ? So confuse

IRediTOTO avatar Sep 02 '21 18:09 IRediTOTO

I feel tab9 still smarter now

IRediTOTO avatar Sep 02 '21 18:09 IRediTOTO

Does this feature work with Jetbrains at all? I can't make it work on PHPStorm.

@igorsgm it should work with JetBrains IDEs. Is the inline completion option in your Tabnine hub is on? What is your tabnine plugin version?

Eransho avatar Sep 02 '21 20:09 Eransho

VS code just release new version inludes inline complete. Should I remove tab9 ? So confuse

I have the same question too. How does this overlap with vscode's suggest preview feature?

Also, this feature doesn't work very well with vscode vim.

hauselin avatar Sep 03 '21 02:09 hauselin