TabNine icon indicating copy to clipboard operation
TabNine copied to clipboard

TabNine downloading files from my OneDrive

Open pinholucas opened this issue 3 years ago • 8 comments

  • OS version: Win10
  • Editor: VSCode
  • Editor version: 1.55
  • Programming language: js
  • TabNine extension version: 3.2.17
  • Engine version (could be located within Tabnine Hub): ?

20 minutes ago, TabNine started to download random files from my OneDrive without my authorization.

image image

Excuse my French, but what the fuck is happening?!

pinholucas avatar Apr 08 '21 04:04 pinholucas

Hi @pinholucas Thanks for reporting this to us. It is indeed a bug. The local model tries to learn your local project and it seems like it followed some external links to your one drive. These files were only downloaded to your machine, and used by the local model, so at no time was any of this data externalized out of your machine. Still, this obviously should not happen and we will fix it asap. Meanwhile, you can use a .Tabnineignore file to exclude these files or folders. See more information here. Does your project contain any symbolic links to onedrive?

Shai

shaiahr avatar Apr 08 '21 06:04 shaiahr

No, no links to anything in OneDrive (It's a Next.JS project btw)... It's strange that it tried to read AutoCAD & txt files. I think that it should be better to let the user choose what folders TabNine can access.

pinholucas avatar Apr 08 '21 14:04 pinholucas

We're trying to keep things as simple as possible, so we don't want to force users to configure accessible folders. Tabnine, by default, scans all folders up to the project root. It identifies that root based on version control settings (e.g. git). Usually this is good enough, but when it's not, the user can configure what files and folders to exclude using ignore files. Are you working on a git project (i.e. is there a .git folder at the root of your project)?

shaiahr avatar Apr 08 '21 14:04 shaiahr

Yes, it's a git project.

pinholucas avatar Apr 08 '21 19:04 pinholucas

That is strange. I'd like to ask for your tabnine logs files. Can you please open a ticket with our support and we'll continue there?

shaiahr avatar Apr 12 '21 09:04 shaiahr

Sorry for the delay, yes no problem. How can I do this?

pinholucas avatar Apr 15 '21 15:04 pinholucas

Sorry, my bad for not posting the address. Please send an email to [email protected] Mention this issue in the email so we'll know how to refer to it.

shaiahr avatar Apr 18 '21 04:04 shaiahr

I encountered a bug today where tabnine automatically downloads OneDrive files I have both idea and vscode with plugins installed idea opened a Java project (version control using git), but the project path is not in the OneDrive directory vscode just opens a few temporary files It downloads files from OneDrive for about two hours and downloads a lot of my next cloud backup data (.php files) image

PlayerYao avatar Sep 07 '22 06:09 PlayerYao

I was just working in VSCode when I got a windows notification that said Tabnine was downloading files from my OneDrive. It was able to download a few before I stopped it, and I'm not sure which files it downloaded, but I do have have personal files on my OneDrive that I do not want extensions to access. I also don't recall giving permission for this extension to access files in my OnDrive

thrivingproject avatar Nov 01 '22 16:11 thrivingproject

@thrivingproject very interested in reproducing it. Does the project you're working on have a .git directory? Tabnine looks for the project root by climbing the directory structure, and this sounds like a bug that makes it climb too far.

yahave avatar Nov 01 '22 17:11 yahave

Hi, the project does not have a .git directory. The directory path is /c/Users/thrivingproject/Documents/business and my onedrive path is /c/Users/thrivingproject/OneDrive. But that doesn't really explain why it chooses to go into the OneDrive directory, as there are directories with .git subdirectories in Documents directory, so if it's looking for a .git directory it doesn't need to go all the way back to the thrivingproject directory.

thrivingproject avatar Nov 01 '22 18:11 thrivingproject

Looking at the code, what seems to be happening is:

  1. Tabnine starts at /c/Users/thrivingproject/Documents/business and identifies that it is not a project root. It has no .git directory or other indications of project root (Cargo.toml,.tabnine_root, etc.)
  2. Tabnine starts climbing the directory tree looking for said indications of a project root. There is a bug in the code that does the climbing, and it does not stop climbing until it finds "indications of project root" or reaches the top-level directory.
  3. Once it establishes the top-level directory as thrivingproject it tries to explore everything under it and see what it needs to take into account for inference.

I'll take it to the team, but until we release a fix, can you please check if adding a .tabnine_root file under /c/Users/thrivingproject/Documents/business prevents Tabnine from climbing beyond that directory (and in particular to your OneDrive)?

@yonip23 @dimacodota

yahave avatar Nov 01 '22 18:11 yahave

@yahave It seems like the problem isn't only about the root folder, because in my case Tabnine was accessing files on a different drive, where I don't have any code. The problem still persists, and it is really annoying. Had to stop using Tabnine until further investigation.

hwndmaster avatar Nov 28 '22 09:11 hwndmaster

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jan 27 '23 10:01 stale[bot]