hacker-blocks icon indicating copy to clipboard operation
hacker-blocks copied to clipboard

Add monaco editor

Open jatinkatyal13 opened this issue 5 years ago • 9 comments

Replace Ace Editor that we currently use with Monaco Editor for Ember.

jatinkatyal13 avatar May 22 '19 09:05 jatinkatyal13

I would like to work on this issue!!

shubhamofbce avatar May 22 '19 18:05 shubhamofbce

@jatinkatyal13 I would like to like to work on this issue but would like some help from you. Can you please share some links with relevant info so I can get started with this issue.

sameshl avatar May 25 '19 07:05 sameshl

I am willing to take this!

sudo-nan0-RaySK avatar May 25 '19 19:05 sudo-nan0-RaySK

The version of ember-monaco you have suggested is no doubt maintained. However it has issues regarding CommonJS transforms. It is due to a node module named 'penpal'. The older ember-monaco-editor has no such dependencies however. Should i go forward with it?

sudo-nan0-RaySK avatar May 26 '19 06:05 sudo-nan0-RaySK

What issues exactly? We already are using that plugin online CodingBlocks frontend. Can you elaborate the issue or a link perhaps?

abhishek97 avatar May 27 '19 04:05 abhishek97

Okay so when i install the above add-on, what i get is an error stating unknown transformation name 'cjs'. I have used the above add on in my project, it works fine in there but with hacker-blocks frontend I get this error. Only difference is the ember version.

sudo-nan0-RaySK avatar May 27 '19 16:05 sudo-nan0-RaySK

Have you tried installing https://github.com/rwjblue/ember-cli-cjs-transform ?

abhishek97 avatar May 27 '19 17:05 abhishek97

Yes, That's the first thing I did. Also the Monaco Editor for Ember add on uses it internally for importing Penpal.Like have a look at its index.js

sudo-nan0-RaySK avatar May 28 '19 08:05 sudo-nan0-RaySK

@abhishek97 is this one open for working? I have experiences using ace editor so might be suitable for me 😄 Thank you!

RAJAGOPALAN-GANGADHARAN avatar Jun 17 '19 14:06 RAJAGOPALAN-GANGADHARAN