codingblocks.online.projectx icon indicating copy to clipboard operation
codingblocks.online.projectx copied to clipboard

Published 20 hours ago • verified publisher icon coding-blocks

Deprecate Jquery

Open abhishek97 opened this issue 5 years ago • 14 comments

Jquery was included by default in Ember.js. Though it has served its purpose well, current state of ember and browsers no longer needs Jquery. Ember also has officially deprecated Jquery, we also wish to do the same.

Task: Remove all usages of jQuery throughout the project. One way to get started is to remove @ember/jquery package from package.json and re-rerun yarn install and check for errors due to absence of Jquery and fix them with suitable Vanilla JS / Ember code.

abhishek97 avatar May 27 '19 07:05 abhishek97

I want to try this. Actually i don't know ember can i still be able to solve this @abhishek97

sourabh1031 avatar May 27 '19 10:05 sourabh1031

i removed the @ember/jquery package from package.json file and did yarn install but no error came

sourabh1031 avatar May 27 '19 11:05 sourabh1031

You must run the project. I don't know ember, you can start now https://guides.emberjs.com/release/

abhishek97 avatar May 27 '19 17:05 abhishek97

@abhishek97 I ran the project before submitting the PR, it was working fine. Could you please tell me what's going wrong with this ?

farhan787 avatar May 28 '19 14:05 farhan787

@farhan787 before sending pr you must atleast inform that you are working on the use . @abhishek97 i think sending pr in this way is not good because if one will inform that he is working on the issue then other people can try different issues in the meantime

sourabh1031 avatar May 28 '19 14:05 sourabh1031

@sourabh1031 I think multiple people can try to fix the same issue, as I also don't know Ember. I'm new to it because I worked with React.js. So, there are less chances that everybody will be able to fix it and it's competitive where it matters who solved it first. Other people have also submitted PRs on issues on which I've already submitted but because mine was first and correct so my PR was merged.

farhan787 avatar May 28 '19 17:05 farhan787

@farhan787 okay i agree with you but i was just saying that writing in the issue description is also good. By the way no problem ,we all can try so go with it

sourabh1031 avatar May 28 '19 23:05 sourabh1031

@abhishek97 please review it :-)

farhan787 avatar May 30 '19 07:05 farhan787

@abhishek97 please review this one and I hope it's the way you wanted it to be :-)

farhan787 avatar Jun 19 '19 20:06 farhan787

@abhishek97 I want to work on this issue please assign. : )

chtushar avatar May 13 '20 15:05 chtushar

@chtushar yes, go ahead. We don't "assign" issues here.

abhishek97 avatar May 13 '20 15:05 abhishek97

Okay Thanks : ). On which branch should I send the pull request?

chtushar avatar May 13 '20 15:05 chtushar

@abhishek97 Can I work on this issue?

nitesh585 avatar May 15 '20 03:05 nitesh585

@abhishek97 I'm getting an Authorization error after setting up and starting the repo. Screenshot from 2020-05-13 23-47-07

chtushar avatar May 15 '20 06:05 chtushar