boss icon indicating copy to clipboard operation
boss copied to clipboard

Added Conflicting Claims count pill on Claims listing

Open prathambatra opened this issue 5 years ago • 4 comments

Signed-off-by: prathambatra [email protected] fixes #399 Screenshot from 2020-06-06 01-40-09 Screenshot from 2020-06-06 01-40-19 Screenshot from 2020-06-06 01-40-25

For optimizing, I have reduced db queries by using the fact if a claim is a conflict to another claim then vice versa is also true. conflictKey is used for the same type of claims and for all these claims only 1 db count query is performed. if there are no conflicts, no badge is shown.

prathambatra avatar Jun 05 '20 20:06 prathambatra

Thanks @prathambatra, for opening the pull request! 🙌

One of our mentors will review the pull request soon. ✅

Star ⭐ this project and tweet 🐦 about your contributions.

@hereisnaman

prathambatra avatar Jun 07 '20 14:06 prathambatra

@hereisnaman I just realized that there is no need for a DB query because we are querying for all the claims on claims/view page. so we can use our conflict logic to find conflicts count without any query. We can do this in linear time (total number of claims) using a hashmap. should I proceed in this way?

prathambatra avatar Jun 13 '20 14:06 prathambatra

@hereisnaman I just realized that there is no need for a DB query because we are querying for all the claims on claims/view page. so we can use our conflict logic to find conflicts count without any query. We can do this in linear time (total number of claims) using a hashmap. should I proceed in this way?

The claim view page is paginated, why are we querying all the claims?

0xnmn avatar Jun 14 '20 06:06 0xnmn