qpixel icon indicating copy to clipboard operation
qpixel copied to clipboard

Deleted user shows as a link in posts list but it's not actually a link

Open cellio opened this issue 4 years ago • 3 comments

Currently visible on Judaism:

screenshot

The "posted by" text for the top question says "deleted user" and it's rendered as a link. Clicking on it does nothing visible. Hovering over it shows that the link is to https://judaism.codidact.com/categories/32#.

On the question, the user card shows it's a deleted user and there's no link:

screenshot

If there's nothing to link to, then we probably shouldn't linkify the name on the posts list.

(That said, as an admin I thought I could see deleted users' profile pages. This might have been a special deletion, though, so maybe this only happens in that case?)

cellio avatar Oct 24 '21 22:10 cellio

I'm marking this medium because of the decoy link. It's a rare case and when that question isn't at the top of the posts list maybe it won't be that important. But I'm also hoping it's not hard.

cellio avatar Oct 24 '21 22:10 cellio

As a mod/admin you can see deleted user's profiles, not destroyed users. The former is a soft-delete; the latter is completely removed from the database. That said, completely destroying a user does cause issues like the 500 this was causing earlier fairly often, so I'm reconsidering whether we really need that ability or whether soft-deletes work just fine.

ArtOfCode- avatar Oct 24 '21 22:10 ArtOfCode-

Ah, that was a destruction not a mere deletion. I forgot we had those. Maybe they cause too much trouble? If there are other effects of destruction (I believe there are), we can presumably still do those -- "destroy" becomes an action, not an account state, though the mod/admin-visible profile should probably indicate that this action was taken.

cellio avatar Oct 24 '21 22:10 cellio