Add suggested edits to tags

[cellio]

Related: https://meta.codidact.com/questions/279616

Also https://meta.codidact.com/posts/280107

Also blocks https://meta.codidact.com/posts/288633

Users without the Edit ability can suggest edits to posts. However, users without the Edit Tags ability have no way to suggest tag edits, and they have to be able to suggest some in order to gain the ability.

Here is what I see as a user with the ability:

A user without the privilege does not see a button there. Please add a "suggest edit" button there.

Just adding the button isn't enough, though -- the fact that there is a pending edit needs to be visible. At minimum, the tag page for users with the ability should show that there's a pending edit, like posts do, and allow for review.

Tags are less visible than posts, so this might not be enough -- people will have to come across the tag and its pending edit. The simplest thing might be to annotate the tag in the tags list somehow -- a special mark next to it, maybe -- to show that there is a pending edit. This way reviewers can scan the tags list, notice where edits are waiting, and go there. It's not as good as something that's more pushy, but we haven't designed something more pushy yet and this would at least let people get started.

[cellio]

This issue has come up again in chat a few times recently.

On visibility, these should be part of the suggested edits linked from the category. Complication: a tag belongs to a tag set and a tag set can be used in more than one category. I think the easiest and most intuitive thing from the user perspective is that the item shows up in the "Edits" list of all categories that use the tag; some people will see it more than once, but that seems ok.

[cellio]

I think the work we want here is:

• Add "suggest edit" in place of the "edit" button on tag pages, for users without the ability.
• Include suggested tag edits in pending edits for all categories that use the tag. With a recent change, the "edit" button now lights up if there are pending edits, so that will make tag edits more visible.

That might be enough, without also marking tags with pending edits in the tags list somehow. Let's try this first and see if it meets the need.

[cellio]

If integrating this with the "Edits" indicator is too hard (because that expects a list of posts), can we light up the "Tags" indicator when there's an edit pending, and then somehow mark the tag in the list? Would that be less hard, @ArtOfCode- ?

We need some way to (enable and) surface tag edits so that people can propose new tag descriptions or edit existing ones; I'm not too picky about how we surface them.

[trichoplax]

I don't have any insight into whether including tag edits in the Edits tab would be challenging, so this suggestion might be redundant, but just in case:

Would it help to have an additional tab "Tag edits"? This would mean, for example, the Q&A category would have tabs "Posts", "Tags", "Edits", "Tag edits".

I'm not sure what's easier from a coding perspective, but I'd rather think about what's easier from a user perspective first, rather than being led by the code.

In principle, a user could have the Edit ability but not the Edit tags ability, or could have the Edit tags ability but not the Edit ability. As a user I'd expect to see either of the following:

• Separate tabs ("Edits" and "Tag edits") which each show an indicator only if I have the corresponding ability.
• One tab ("Edits") which only shows an indicator if there are edits or tag edits which I have the ability to review. So I would see no indicator if there are only tag edits to review and I only have the Edit ability.

Which of these would work best for users?

[cellio]

How about this:

• "Edits" behaves as now (lights up if there are post edits).
• "Tags" gets an indicator if there are pending tag edits.
• Tags page (the list of tags) gets a link like "review suggested edits", which goes to a new page.
• Edits page (the place with the list of post edits) gets some additional text about also checking the Tags page for pending edits.

That's a little more clunky than is ideal, but it would work, and it wouldn't add another thing to the category bar (likely to be not good on a phone). Is it doable?

If we had that, then we could add support for suggested edits and people would actually be able to review them, unblocking a lot of things.