qpixel icon indicating copy to clipboard operation
qpixel copied to clipboard

Not allowed to save a blank tag wiki

Open MoshiKoi opened this issue 2 years ago • 1 comments

If you type anything into the tag wiki textbox while editing, and then delete it, it will not allow you to save the tag, showing a greyed out Save button and a red text area.

image

I believe this is caused by the same issue as #945, caused by it trying to apply post validation to the tag wiki.

MoshiKoi avatar Jun 04 '23 21:06 MoshiKoi

I noticed it several times, too.

Reloading the page displays a "draft loaded" message and the save button becomes active and you can save the blank wiki without problem. I use Firefox 113.0.2. Hope this helps.

lorenzodonati avatar Aug 08 '23 20:08 lorenzodonati

This is not a bug with applying validation, this is an issue of not passing correct values (like, at all) to character counter. The default for mdhint is 30 and 30K chars for min and max boundaries respectively. We just need to pass the proper values (Easy to tackle for me as I've made char_count a proper partial).

Oaphi avatar Aug 03 '24 13:08 Oaphi

On a related note, we should probably not allow to create tag wikis of 30K chars or at the very least limit it to 30K chars as currently we only have the DB's restriction of 65 535 single-byte chars to work with, leading to things like in the attached Screenshot from 2024-08-03 16-16-23 screenshot.

Oaphi avatar Aug 03 '24 13:08 Oaphi