qpixel icon indicating copy to clipboard operation
qpixel copied to clipboard

Hitting enter in a synonyms field adds a `[]()` to the tag wiki

Open MoshiKoi opened this issue 2 years ago • 4 comments

I tried to add pie as a synonym of Proto-Indo-European on L&L, but by reflex hit the enter key when I finished typing the name into the field. This, for some reason, caused the wiki field to be filled in with []().

image

Currently tested using Edge on Windows 11; I haven't tested other browsers yet.

MoshiKoi avatar Jun 04 '23 21:06 MoshiKoi

Related issue? https://meta.codidact.com/posts/288646

MoshiKoi avatar Jun 22 '23 10:06 MoshiKoi

I've edited that related issue to mention I saw it on Firefox on Fedora, so it's not just Edge on Windows if this happens to have a shared root cause.

trichoplax avatar Jun 22 '23 11:06 trichoplax

The core problem is markdown_tools partial's link insertion button being of type submit, causing click handler to be triggered. @ArtOfCode- - since the button's no longer in a form and requires JS to operate either way, what'd you say about just switching to type="button"? I don't see any downsides to doing this now, but pinging you just in case as you were the one to fix https://github.com/codidact/qpixel/issues/264.

Oaphi avatar Oct 23 '23 06:10 Oaphi

@Oaphi no reason that shouldn't work that I can see

ArtOfCode- avatar Oct 30 '23 00:10 ArtOfCode-