core icon indicating copy to clipboard operation
core copied to clipboard

Project Logo Not Displaying on Project Github Page

Open jflopezfernandez opened this issue 5 years ago • 3 comments

For some reason the project image isn't display correctly. When I click on the link that's being displayed instead, it takes me to a page containing only the following message:

Error Message

The image info also says the image is only fifteen bytes, so I'm not sure what's going on.

Image Details

jflopezfernandez avatar Jan 30 '20 04:01 jflopezfernandez

This is why what I wrote on Discord last Monday is important:

@ozewski cc: @luap42 re: https://github.com/codidact/core/pull/30/commits/4c51350e08a2be86d0dbecdba273e99eb874f713

Was this change done in the GitHub UI?

Is there any way to commit the logo-codidact.png to an assets folder in the core repo and source it from there in the README?

What happened?

I merged codidact/landing-page/pull/30.

Repos should be self-containing, or use submodules (or subtrees) - judiciously. If we go with the latter approach, a dedicated repo for assets/artwork is in order.

ranolfi avatar Jan 30 '20 04:01 ranolfi

Quick fix: Reference a release tag, but never master: https://raw.githubusercontent.com/codidact/landing-page/live/2020-01-07T2316Z/source-assets/img/logo-codidact.png.

Proper fix: copy the asset to this repo and source it from here instead.

FYI, future assets source should be in the artwork repo. Re: https://github.com/codidact/landing-page/issues/35

ranolfi avatar Feb 07 '20 06:02 ranolfi

FYI, future assets source should be in the artwork repo. Re: codidact/landing-page#35

I think this should be the best solution. The files in the artwork repo would almost never change, hence this seems to be a stable solution.

luap42 avatar Feb 09 '20 21:02 luap42