ddf icon indicating copy to clipboard operation
ddf copied to clipboard

DDF-6386 Add support for source id and metacard type for csv metacard transforms

Open derekwilhelm opened this issue 2 years ago • 9 comments

What does this PR do?

Forward port and conflict resolution of #6387 :

Downstream projects need to create CSV exports that include the source identifier and metacard type name. The current code only supports exporting data that is contained in a metacard attribute. However, the source identifier and metacard type name are stored separately from the attributes.

This PR also creates a constant in MetacardType for the string "metacard-type", which was being defined multiple times in DDF and in downstream projects.

This PR also includes a forward port of #6501 which adds UTC dates when exporting metacards in CSV format.

Who is reviewing it?

@glenhein @jlcsmith @jrnorth

Select relevant component teams:

@codice/core-apis @codice/data

Ask 2 committers to review/merge the PR and tag them here.

@andrewkfiedler @clockard

How should this be tested?

Build with a downstream project that provides a UI capable of creating a CSV export. The export should include the source id and metacard type. Make sure that the exported data includes the correct values for these fields.

Export a metacard as a CSV file. Verify that the generated CSV uses UTC dates. For example: image

Any background context you want to provide?

What are the relevant tickets?

Fixes: #6386

Screenshots

Checklist:

  • [ ] Documentation Updated
  • [ ] Update / Add Threat Dragon models
  • [ ] Update / Add Unit Tests
  • [ ] Update / Add Integration Tests

Notes on Review Process

Please see Notes on Review Process for further guidance on requirements for merging and abbreviated reviews.

Review Comment Legend:

  • ✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist.
  • ❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.
  • ❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.

derekwilhelm avatar Aug 15 '22 20:08 derekwilhelm

build now

derekwilhelm avatar Aug 15 '22 20:08 derekwilhelm

Internal build has been started, your results will be available at build completion.

cxddfbot avatar Aug 15 '22 20:08 cxddfbot

Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI.

cxddfbot avatar Aug 15 '22 22:08 cxddfbot

build now

derekwilhelm avatar Aug 16 '22 18:08 derekwilhelm

Internal build has been started, your results will be available at build completion.

cxddfbot avatar Aug 16 '22 18:08 cxddfbot

Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI.

cxddfbot avatar Aug 16 '22 20:08 cxddfbot

build now

derekwilhelm avatar Aug 22 '22 16:08 derekwilhelm

Internal build has been started, your results will be available at build completion.

cxddfbot avatar Aug 22 '22 16:08 cxddfbot

Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI.

cxddfbot avatar Aug 22 '22 18:08 cxddfbot

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within 7 days. Thank you for your contributions.

stale[bot] avatar Oct 29 '22 04:10 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within 7 days. Thank you for your contributions.

stale[bot] avatar Jan 05 '23 05:01 stale[bot]