pydatastructs Allow using array for constructing binary trees

Allow using array for constructing binary trees

Open czgdp1807 opened this issue 5 years ago • 9 comments

Description of the problem

Idea of using arrays for constructing binary trees originated from https://github.com/codezonediitj/pydatastructs/issues/38#issuecomment-562864441 which uses arrays for constructing binary heaps. The challenge is to make the change without breaking existing API. One approach can be using keyword arguments like, elements and the transformed API would look like,

def __new__(cls, key=None, root_data=None, comp=None,
                is_order_statistic=False, *args, **kwargs):

If the above is done then the existing tests for binary_trees.py can be shortened.

Example of the problem

References/Other comments

Dec 07 '19 16:12 czgdp1807

This can be done by passing the array of elements and in __new__ we can insert every element of passed array in object.tree , right?

Dec 14 '19 09:12 23umesh

Yes we can do that. A PR would be better for explaining the solution.

Dec 14 '19 18:12 czgdp1807

@akshaygoelakki Feel free to start your work on this. Whenever you will create a PR, it will be linked to this issue and it will show up in assignee section.

Mar 07 '20 09:03 czgdp1807

I want to work on this issue. So kindly assign this issue to me .