pydatastructs icon indicating copy to clipboard operation
pydatastructs copied to clipboard

Add flake8 quality checks to .travis.yml

Open czgdp1807 opened this issue 4 years ago • 6 comments

Description of the problem

Example of the problem

References/Other comments

czgdp1807 avatar Jan 31 '21 12:01 czgdp1807

can i take this issue as the part of swoc and add github action instead of travis.yml ? both works same btw

hpnightowl avatar Feb 04 '21 23:02 hpnightowl

Sure. Make separate PRs for migrating to Github action and adding flake8 checks.

czgdp1807 avatar Feb 05 '21 04:02 czgdp1807

can you as this task with SWOC tag? i am doing pr

hpnightowl avatar Feb 05 '21 04:02 hpnightowl

@czgdp1807 for which python package version should i go? i have make for all 3 version like 3.7 3.8 3.9 https://github.com/hpnightowl/pydatastructs/commit/d0ac9135bab07392d416b46c468f0483aa5c3f1a

hpnightowl avatar Feb 05 '21 05:02 hpnightowl

I think anything greater than 3.5 should work(or whatever is there in the travis.yml).

czgdp1807 avatar Feb 05 '21 07:02 czgdp1807

I will label your PR with the appropriate labels.

czgdp1807 avatar Feb 05 '21 07:02 czgdp1807