editor.js
editor.js copied to clipboard
hotfix: add popular grammar checker extension node names
Fix: #810
In this PR I have fixed the issue of getting the entire block deleted when the editor would press the backspace key. This issue occurs when you have one of the grammar checker chrome extensions enabled. It is likely that it may occur with other extensions too but I have fixed it for a few grammer checker extensions.
Thanks for the PR. Could you please remove all the changes that are not related to the issue you're resolving? It would be easier to review only the actual change.
If you want to fix some code style, please do it via the separate PR.
Sorry for the mess, I have prettier installed in my IDE, it changed the existing code style. I have updated the code in the latest commit. Now you can review only the changes related to the fix.
Thanks :)
Could you please add a line to the Changelog?
Could you please add a line to the Changelog?
Apologize, I don't understand which changelog I should update.
Any update on this?
Hello, @getanwar. Please, add the information about your fix to CHANGELOG.md
Can you please let us know the update on this hotfix? Causing a lot of issues for our customers also because of these extensions.
Thanks. We'll include it in the upcoming release. ETA: Nov, 25th
Pull the next
branch and fix the Changelog, please. Or give me push-access to this branch.
@neSpecc I have granted you push permission to this repository!
@getanwar I still have no access to this branch.
Please, pull the latest changes and update a change: move the new line under the ###2.27.0
section
Or give me access and I'll do all the work.
Hi, @getanwar. Could you fix CHANGELOG.md
? We want to take this fix to the next release.
Hi, @getanwar. Could you fix
CHANGELOG.md
? We want to take this fix to the next release.
Done
@getanwar, thank you ❤️
It looks like this fix didn't make it into the latest release 2.27.0-rc.4. I wanted to check if it also worked with webspellchecker which presents the same issue but I couldn't find the isExtensionNode
function in the dist code
It looks like this fix didn't make it into the latest release 2.27.0-rc.4. I wanted to check if it also worked with webspellchecker which presents the same issue but I couldn't find the
isExtensionNode
function in the dist code
You can check 2.27.0-rc.4 with your extension and tell us whether bugs still occurs or not
Yes, I'm afraid they still occur. But, I don't know why if I CMD+F isExtensionNode
in the dist/editor.js
file that I find in node_modules/@editorjs/editorjs
I get no results. Must be a misunderstanding of mine that I think I should find that function there
I tried with the v2.27.0-rc.3 which does have the isExtensionNode
but the bug still occurs. Checking if I can somehow trigger the fix
The fix is under rc.4, not 3
Ok, I tried with the rc.4 and the issue still occurs.
P.S.
https://github.com/codex-team/editor.js/blob/v2.27.0-rc.3/src/components/dom.ts#L559 https://github.com/codex-team/editor.js/blob/v2.27.0-rc.4/src/components/dom.ts#L559