AskDevs icon indicating copy to clipboard operation
AskDevs copied to clipboard

fixing some styling bugs

Open bruxx-6243 opened this issue 2 years ago • 6 comments

Hey @codewithvoid check out some changes I've made. On small screen the width full was creating this small issue. 2022-12-08_18-45-01

And when we're fetching data for those user image that can't be load I think it's better to specify exactly the alt with the name of the user 2022-12-08_18-58-01

For example for some image from this twitter url is giving 404 status for those who live in region like Russia. @codewithvoid How do you think if we set a default profile picture when the image src is not correctly fetched???

bruxx-6243 avatar Dec 08 '22 17:12 bruxx-6243

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ask-devs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 30, 2024 8:41pm

vercel[bot] avatar Dec 08 '22 17:12 vercel[bot]

@codewithvoid I mean here a default profile picture just in the case the image is not provided from the src

bruxx-6243 avatar Dec 08 '22 17:12 bruxx-6243

@codewithvoid did you review the code?

bruxx-6243 avatar Dec 10 '22 14:12 bruxx-6243

Thanks @bruxx-6243 for making the changes. I think suggestions related to images are valid. (alt text and default profile picture)

@PriteshKiri is already fixing the width issue in his PRs.

Also, can you sync your changes once..I am seeing additional files in data/users directory.

codewithvoid avatar Dec 11 '22 20:12 codewithvoid

Done ✅ @codewithvoid

bruxx-6243 avatar Dec 12 '22 17:12 bruxx-6243

I am seeing some additional files in this change due to format fix. I have sent it separately in #121

codewithvoid avatar Dec 12 '22 20:12 codewithvoid