social-platform-donut-frontend icon indicating copy to clipboard operation
social-platform-donut-frontend copied to clipboard

Google calendar integration

Open AuraOfDivinity opened this issue 4 years ago • 18 comments

#349

Initial setup for the frontend portion of the Google Calendar integration. Currently, the calendar is displayed on a separate page and is accessed by clicking on the "My Calendar" button on the dashboard.

Status

However, as discussed with @jaskirat2000 and @devesh-verma There's a lot to be changed from the current implementation mainly the way the integration is accessed and how the integration is presented (i.e a popup instead of separate page). These changes will be made in the coming days.

AuraOfDivinity avatar Mar 02 '20 16:03 AuraOfDivinity

Deploy preview for donut-frontend-r ready!

Built with commit 8eba070c90b4fabbe4c50a59f0f060f6c714bddd

https://deploy-preview-350--donut-frontend-r.netlify.com

netlify[bot] avatar Mar 02 '20 16:03 netlify[bot]

Initial Setup is good, I am looking forward to a new UI as discussed on the Slack. ;) @devesh-verma @vaibhavdaren @Rupeshiya Your thoughts on this?

jaskiratsingh2000 avatar Mar 02 '20 16:03 jaskiratsingh2000

SPA--> no page change

vaibhavdaren avatar Mar 03 '20 14:03 vaibhavdaren

@AuraOfDivinity hey can you please solve merge conflict.

devesh-verma avatar Mar 03 '20 15:03 devesh-verma

@devesh-verma I have fixed the merge conflicts. (Removed the button we had in the news feed since we will be accessing the integration from the sidebar).

I'm currently working on the changes requested by @jaskirat2000.

AuraOfDivinity avatar Mar 04 '20 10:03 AuraOfDivinity

@AuraOfDivinity cool

vaibhavdaren avatar Mar 04 '20 13:03 vaibhavdaren

@jaskirat2000 @devesh-verma @vaibhavdaren I have made changes to the frontend as suggested by @jaskirat2000 . The current iteration can be seen in the following image.

Status

Few issues I'm having at the moment,

  1. The token obtained from the backend potion at https://github.com/codeuino/social-platform-donut-backend/pull/63 is currently stored in the local storage and is not refreshed meaning that the authentication will be required after 15 minutes of use.

  2. Events can only be added at the moment and have to be deleted separately from the google calendar itself.

  3. The add event pop up is not validated.

  4. This calendar is currently accessed through /calendar route. This should be fixed in time when the integrated apps page and the integrated apps part of the sidebar is completed.

The rest of the integration seems to be working fine in my opinion. I would love to hear your thoughts/suggestions and any improvements you would like to see both in terms of frontend and the backend parts.

AuraOfDivinity avatar Mar 07 '20 10:03 AuraOfDivinity

Thanks. I am wondering that will the user have to login again after every 15 mins?

jaskiratsingh2000 avatar Mar 07 '20 12:03 jaskiratsingh2000

Also where is the integration button located specifically for Google Calender?

jaskiratsingh2000 avatar Mar 07 '20 12:03 jaskiratsingh2000

Do you know about refresh tokens?

vaibhavdaren avatar Mar 07 '20 12:03 vaibhavdaren

123

vaibhavdaren avatar Mar 07 '20 12:03 vaibhavdaren

@AuraOfDivinity please squash your commits.

devesh-verma avatar Mar 14 '20 05:03 devesh-verma

use git pull --rebase origin developement from next time.

vaibhavdaren avatar Mar 15 '20 04:03 vaibhavdaren

@jaskirat2000 @devesh-verma @vaibhavdaren Apologies on the delay. I have made requested changes to calendar integration.

  1. The auth token is no longer passed to the frontend as it previously did. As @vaibhavdaren mentioned I'm now resorting to saving the auth token on our database. This means we no longer have to expose the auth token to the clients.

  2. Unlike in the previous iteration, the auth token is refreshed automatically when expired using the refresh token saved in the database. This means no additional logins are required after the initial login.

  3. The add event modal is now validated and displays a set of errors accordingly. (Check the image below).

  4. The calendar is currently accessed through the /calendar route. Once we have completed the app integrations page and the sidebar tray potion of the integrated apps, I'll work on adding the calendar to the required positions.

I have also made the necessary changes to the backend as well https://github.com/codeuino/social-platform-donut-backend/pull/63

updates

Do kindly give me your feedback on this!

AuraOfDivinity avatar Mar 15 '20 20:03 AuraOfDivinity

Nice work!! 👍 well done !! 🥇

vaibhavdaren avatar Mar 17 '20 13:03 vaibhavdaren

@devesh-verma lets merge this.

vaibhavdaren avatar Mar 17 '20 13:03 vaibhavdaren

@AuraOfDivinity Please squash the commits into one. You are good to go. Great work, really appreciable!

Rupeshiya avatar Mar 29 '20 10:03 Rupeshiya

@AuraOfDivinity Please resolve the conflicts.

Rupeshiya avatar Apr 27 '20 17:04 Rupeshiya