CodeTriage icon indicating copy to clipboard operation
CodeTriage copied to clipboard

Rename email rate limiting methods

Open elliotthilaire opened this issue 8 years ago • 2 comments
trafficstars

This is a rename of skip_daily_email? method to emails_rate_limited?

When worked on this Job in the past I misunderstood why skip_daily_email? was skipping emails.

I thought it did more than skip because of the rate limiter. I introduced a bug (now been fixed) because of that misunderstanding. I think this rename makes it more clear.

elliotthilaire avatar Aug 18 '17 10:08 elliotthilaire

With the commit from Nate it should be green

benoittgt avatar Aug 18 '17 15:08 benoittgt

I rebased with master which had some changes to that file. Waiting for tests now.

schneems avatar Mar 20 '18 17:03 schneems