CodeTriage icon indicating copy to clipboard operation
CodeTriage copied to clipboard

Published 20 hours ago • verified publisher icon codetriage

Extract EmailFrequency Value Object

Open DavidRagone opened this issue 8 years ago • 1 comments

Represents the frequency with which email should be sent. Goal is to simplify the logic for "should we send an email now?", which compares user preference with user actions

In trying to understand the logic and tests in https://github.com/codetriage/codetriage/pull/591, I started moving some code around and ended up with this value object extraction. Not sure if it's wanted, but figured I'd share it nonetheless.

DavidRagone avatar Jul 07 '17 18:07 DavidRagone

👍 just wanted an extra comment in there re: "WAIT" and why it's special

nateberkopec avatar Jul 09 '17 23:07 nateberkopec